From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BADCEE14D8 for ; Tue, 26 Sep 2023 11:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbjIZLLx (ORCPT ); Tue, 26 Sep 2023 07:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbjIZLLw (ORCPT ); Tue, 26 Sep 2023 07:11:52 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC98116 for ; Tue, 26 Sep 2023 04:11:42 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3226b8de467so7066073f8f.3 for ; Tue, 26 Sep 2023 04:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695726700; x=1696331500; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=u/MLMSmJRNmBGSS9dRqNvrvgUZYmB0L9NSn0EiK9+Hs=; b=tg1HnJIlfginnSQyWvdanP83HKucSwQFf8FeYPPCLqbZA9DdwBQaJi8EQXpjjC1Xhn pdHYTNETtd77W8EdnfGOguLHiJ7W6BYiv+R2GmFQq8mCRjLR2GQO05LF5LO8Uc/kPVnR 12LdgmsIr+DgyBzC8l9JSdV/trcWoAndp8GpEfTuoDzHZaxhjW+kwQ/+yzRxVbDcE9TR Ihv1r6I14sIqTGHdbfOwHo+CHe32c7YUrCukCoefZ9K8zoGSLApLI4tL2qlpbkr0Xzcs 64FW4XR/gpxypXWSu9JtnWgnqAukZmuKd2CXe2fliejDj3O5Av3MlgCS5bhgcKWXSSpY UCJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695726700; x=1696331500; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u/MLMSmJRNmBGSS9dRqNvrvgUZYmB0L9NSn0EiK9+Hs=; b=WdwfWzbuhs4HfH+B4b6De3t5aXnF5RhzGN3ht8SZ+PSzwJERYOstcl0WR5vDtgPaJv 80vHC0YJL3jf2ridLz3VWKfR8ks0EC/4zG3ORasVAne1eas3PuiTNLCwDncwuapJDspT IeY4BJ/TqUHW5p7Kca+b6vIAa8D42arKLgI0zZncPwgRJ7fFdDx067H15kyHNG2ZEz7+ ZAzvFj+Dy9xPciGbGvpzc8pJAz9uI9jZC5hEXZmsEpGJ5q6JJKLOd/qocwTH9HssFHY8 mfeMSI9rBPe++Bjl/zYvYV81EN7Nn5H63Jr9Bkth0CQGVbA1bLrV2kCL83wMm05LWYWN +pHg== X-Gm-Message-State: AOJu0YylG2DtP42FW/kNMLnjwru1o+7MKL7fWu9XnPuh3MOrAAHUc0vS elkozwFvfQ/GtH75HKgEOCmNJQ== X-Google-Smtp-Source: AGHT+IGgmiei3dmVPVwM/+kLjJAqZ4Dui7T/b864294DUFjV9lzha2Kyb8LLBEIC7UGG1WF/w42vgQ== X-Received: by 2002:adf:9d85:0:b0:323:37af:c7c7 with SMTP id p5-20020adf9d85000000b0032337afc7c7mr1177540wre.69.1695726699756; Tue, 26 Sep 2023 04:11:39 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id t16-20020a5d49d0000000b0031c5b380291sm14405871wrs.110.2023.09.26.04.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 04:11:39 -0700 (PDT) Date: Tue, 26 Sep 2023 12:11:37 +0100 From: Daniel Thompson To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Lee Jones , Jingoo Han , Thierry Reding , Helge Deller , linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel@pengutronix.de, Aisheng Dong , Aisheng Dong Subject: Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend Message-ID: <20230926111137.GA4356@aspen.lan> References: <20230926084612.2074692-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230926084612.2074692-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote: > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > the PWM any more. However this is necessary to suspend because PWM > drivers usually refuse to suspend if they are still enabled. > > Also adapt shutdown to disable the PWM for similar reasons. > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") > Reported-by: Aisheng Dong > Tested-by: Aisheng Dong > Signed-off-by: Uwe Kleine-König Changes proposed look good (and the comment about badly designed boards going to HiZ state we super helpful). Only thing from my is why there is no attempt to disable the PWM from the .remove_new() callback. Daniel.