Re: [PATCH 06/11] pwm: imx-tpm: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions

Jonathan Cameron
2023-10-11T11:22:57Z

On Tue, 10 Oct 2023 09:51:07 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
> care about when the functions are actually used, so the corresponding
> __maybe_unused can be dropped.
>
> Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
> isn't enabled.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/pwm/pwm-imx-tpm.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c
> index 98ab65c89685..da22f9bb367e 100644
> --- a/drivers/pwm/pwm-imx-tpm.c
> +++ b/drivers/pwm/pwm-imx-tpm.c
> @@ -390,7 +390,7 @@ static void pwm_imx_tpm_remove(struct platform_device *pdev)
> clk_disable_unprepare(tpm->clk);
> }
>
> -static int __maybe_unused pwm_imx_tpm_suspend(struct device *dev)
> +static int pwm_imx_tpm_suspend(struct device *dev)
> {
> struct imx_tpm_pwm_chip *tpm = dev_get_drvdata(dev);
>
> @@ -409,7 +409,7 @@ static int __maybe_unused pwm_imx_tpm_suspend(struct device *dev)
> return 0;
> }
>
> -static int __maybe_unused pwm_imx_tpm_resume(struct device *dev)
> +static int pwm_imx_tpm_resume(struct device *dev)
> {
> struct imx_tpm_pwm_chip *tpm = dev_get_drvdata(dev);
> int ret = 0;
> @@ -421,8 +421,8 @@ static int __maybe_unused pwm_imx_tpm_resume(struct device *dev)
> return ret;
> }
>
> -static SIMPLE_DEV_PM_OPS(imx_tpm_pwm_pm,
> - pwm_imx_tpm_suspend, pwm_imx_tpm_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(imx_tpm_pwm_pm,
> + pwm_imx_tpm_suspend, pwm_imx_tpm_resume);
>
> static const struct of_device_id imx_tpm_pwm_dt_ids[] = {
> { .compatible = "fsl,imx7ulp-pwm", },
> @@ -434,7 +434,7 @@ static struct platform_driver imx_tpm_pwm_driver = {
> .driver = {
> .name = "imx7ulp-tpm-pwm",
> .of_match_table = imx_tpm_pwm_dt_ids,
> - .pm = &imx_tpm_pwm_pm,
> + .pm = pm_ptr(&imx_tpm_pwm_pm),
> },
> .probe = pwm_imx_tpm_probe,
> .remove_new = pwm_imx_tpm_remove,