From: Greg KH <greg@kroah.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: stable@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@pengutronix.de, Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH stable 5.4.y] pwm: hibvt: Explicitly set .polarity in .get_state()
Date: Thu, 12 Oct 2023 19:06:48 +0200 [thread overview]
Message-ID: <2023101241-geologic-barley-dbe6@gregkh> (raw)
In-Reply-To: <20231009134309.243860-1-u.kleine-koenig@pengutronix.de>
On Mon, Oct 09, 2023 at 03:43:09PM +0200, Uwe Kleine-König wrote:
> [ Upstream commit 6f57937980142715e927697a6ffd2050f38ed6f6 ]
>
> The driver only both polarities. Complete the implementation of
> .get_state() by setting .polarity according to the configured hardware
> state.
>
> Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs")
> Link: https://lore.kernel.org/r/20230228135508.1798428-2-u.kleine-koenig@pengutronix.de
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this is a backport to 5.4.257. The original was backported to
>
> - v5.10.179 as commit 155b2586de3f171d46c8a1955990d4676487501e
> - v5.15.109 as commit 78559037632b8343b85fb1e2d0b55405c2b73b4a
> - v6.1.24 as commit 98ba763cc91c8e0117ccc28e300640eee52f9b44
> - v6.2.11 as commit 28ab26f6a95b4bda64cba22704484d209aad5417
>
> A direct
>
> git cherry-pick 6f57937980142715e927697a6ffd2050f38ed6f6
>
> on 5.4.257 fails with a conflict, but the same happend on 5.10.y and
> 5.15.y, where it was backported correctly. So
>
> git cherry-pick 78559037632b8343b85fb1e2d0b55405c2b73b4a
>
> works just fine and results in this patch. Cherry-picking
> 78559037632b8343b85fb1e2d0b55405c2b73b4a also works fine on for 4.19.y
> and 4.14.
>
> Note there is a broken sentence in the commit log, s/only/supports/
> would be appropriate. I am unsure however if I'm allowed to fix it or if
> the commit log has to be exactly the same as the original.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-10-12 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 13:43 [PATCH stable 5.4.y] pwm: hibvt: Explicitly set .polarity in .get_state() Uwe Kleine-König
2023-10-12 17:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101241-geologic-barley-dbe6@gregkh \
--to=greg@kroah.com \
--cc=kernel@pengutronix.de \
--cc=linux-pwm@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox