From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827A2CDB474 for ; Mon, 16 Oct 2023 10:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbjJPKpT convert rfc822-to-8bit (ORCPT ); Mon, 16 Oct 2023 06:45:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbjJPKpS (ORCPT ); Mon, 16 Oct 2023 06:45:18 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2753695 for ; Mon, 16 Oct 2023 03:45:16 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S8DJY3KTHz6K8tv; Mon, 16 Oct 2023 18:44:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 16 Oct 2023 11:45:13 +0100 Date: Mon, 16 Oct 2023 11:45:12 +0100 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Thierry Reding , Florian Fainelli , Broadcom internal kernel review list , , , Subject: Re: [PATCH v2 04/11] pwm: brcmstb: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Message-ID: <20231016114512.0000556a@Huawei.com> In-Reply-To: <20231013174204.1457085-17-u.kleine-koenig@pengutronix.de> References: <20231013174204.1457085-13-u.kleine-koenig@pengutronix.de> <20231013174204.1457085-17-u.kleine-koenig@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Fri, 13 Oct 2023 19:42:09 +0200 Uwe Kleine-König wrote: > This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to > care about when the functions are actually used, so the corresponding > > Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM > isn't enabled. > > Acked-by: Florian Fainelli > Signed-off-by: Uwe Kleine-König Given the bit I commented on in v1 has gone away... Reviewed-by: Jonathan Cameron > --- > drivers/pwm/pwm-brcmstb.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c > index b723c2d4f485..0fdeb0b2dbf3 100644 > --- a/drivers/pwm/pwm-brcmstb.c > +++ b/drivers/pwm/pwm-brcmstb.c > @@ -259,7 +259,6 @@ static int brcmstb_pwm_probe(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int brcmstb_pwm_suspend(struct device *dev) > { > struct brcmstb_pwm *p = dev_get_drvdata(dev); > @@ -275,17 +274,16 @@ static int brcmstb_pwm_resume(struct device *dev) > > return clk_prepare_enable(p->clk); > } > -#endif > > -static SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, > - brcmstb_pwm_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, > + brcmstb_pwm_resume); > > static struct platform_driver brcmstb_pwm_driver = { > .probe = brcmstb_pwm_probe, > .driver = { > .name = "pwm-brcmstb", > .of_match_table = brcmstb_pwm_of_match, > - .pm = &brcmstb_pwm_pm_ops, > + .pm = pm_ptr(&brcmstb_pwm_pm_ops), > }, > }; > module_platform_driver(brcmstb_pwm_driver);