From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88302C0032E for ; Fri, 20 Oct 2023 14:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377534AbjJTOVY (ORCPT ); Fri, 20 Oct 2023 10:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377541AbjJTOVX (ORCPT ); Fri, 20 Oct 2023 10:21:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05321D5D; Fri, 20 Oct 2023 07:21:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EFABC433C7; Fri, 20 Oct 2023 14:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697811680; bh=Sec4O0KSkSkahb8ChGos0WpVoRI0WMt1czHDEPGpGl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fk1B4SIJRfOw6CSnTzkzYMkE/x3c54CLHy1M83x5hJJ5ZfslOTX1kXRRSOvLHJQO/ jgxu4wkEJu8lU78QW8/QNbFbw22eIloRiTiDupXbkJlfTI+gwvMd7D51AiTgkTtCId 7jL9cNcC6jSDWDo+yYAqx2NoQMC89OpGL997DufNCox/0GYQvcSKpMPSlwg2UT09gw +4pY6+5LfIZGrvRhMmQvOi1xE68es+XFGsnAW/ZD9w6QVtR6lXqj4QTQnCQL6JLUhu Zr+ftbCPS/R7MTC+bCcIdefvZk2xc0SBSAU2M2sajUZEfOGjNOKn0uj7j1ZJA2xtGa QHmEnqWalNKTg== Date: Fri, 20 Oct 2023 15:21:15 +0100 From: Conor Dooley To: William Qiu Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, Emil Renner Berthing , Rob Herring , Thierry Reding , Philipp Zabel , Krzysztof Kozlowski , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Hal Feng , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v6 1/4] dt-bindings: pwm: Add OpenCores PWM module Message-ID: <20231020-barley-rosy-92c3688cd515@spud> References: <20231020103741.557735-1-william.qiu@starfivetech.com> <20231020103741.557735-2-william.qiu@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c0ct6Bl9DHRpBcKH" Content-Disposition: inline In-Reply-To: <20231020103741.557735-2-william.qiu@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org --c0ct6Bl9DHRpBcKH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Krzysztof, William, On Fri, Oct 20, 2023 at 06:37:38PM +0800, William Qiu wrote: > Add documentation to describe OpenCores Pulse Width Modulation > controller driver. >=20 > Signed-off-by: William Qiu > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Hal Feng > --- > .../bindings/pwm/opencores,pwm-ocores.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/opencores,pwm-o= cores.yaml >=20 > diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm-ocores.y= aml b/Documentation/devicetree/bindings/pwm/opencores,pwm-ocores.yaml > new file mode 100644 > index 000000000000..0f6a3434f155 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/opencores,pwm-ocores.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/opencores,pwm-ocores.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: OpenCores PWM controller > + > +maintainers: > + - William Qiu > + > +description: > + OpenCores PTC ip core contains a PWM controller. When operating in PWM= mode, the PTC core > + generates binary signal with user-programmable low and high periods. A= ll PTC counters and > + registers are 32-bit. > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + enum: > + - opencores,pwm-ocores What does the extra "ocores" suffix add, when it just repeats the vendor prefix? > + - starfive,jh71x0-pwm Krzysztof, did you approve this generic compatible? And the whole thing looks like it should really be something like items: - enum: - starfive,jh7100-pwm - starfive,jh7110-pwm - const: opencores,pwm Cheers, Conor. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + "#pwm-cells": > + const: 3 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm@12490000 { > + compatible =3D "opencores,pwm-ocores"; > + reg =3D <0x12490000 0x10000>; > + clocks =3D <&clkgen 181>; > + resets =3D <&rstgen 109>; > + #pwm-cells =3D <3>; > + }; > --=20 > 2.34.1 >=20 --c0ct6Bl9DHRpBcKH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTKM2wAKCRB4tDGHoIJi 0mtkAQDneqmAMFoF4jU76TZRB8bFE0/YWyssA6R28Jn1s3HuawEAiae3jINyrJHZ FyfmraP/Nbf35vRKjhrVBRmITylgPQs= =uBpZ -----END PGP SIGNATURE----- --c0ct6Bl9DHRpBcKH--