Re: [PATCH v3 1/3] pwm: make it possible to apply pwm changes in atomic context

Uwe Kleine-König
2023-10-19T10:52:19Z

[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]

On Wed, Oct 18, 2023 at 03:57:48PM +0200, Hans de Goede wrote:
> Hi Sean,
>
> On 10/17/23 11:17, Sean Young wrote:
> > Some drivers require sleeping, for example if the pwm device is connected
> > over i2c. The pwm-ir-tx requires precise timing, and sleeping causes havoc
> > with the generated IR signal when sleeping occurs.
> >
> > This patch makes it possible to use pwm when the driver does not sleep,
> > by introducing the pwm_can_sleep() function.
> >
> > Signed-off-by: Sean Young <sean@mess.org>
>
> I have no objection to this patch by itself, but it seems a bit
> of unnecessary churn to change all current callers of pwm_apply_state()
> to a new API.

The idea is to improve the semantic of the function name, see
https://lore.kernel.org/linux-pwm/20231013180449.mcdmklbsz2rlymzz@pengutronix.de
for more context. I think it's very subjective if you consider this
churn or not. While it's nice to have every caller converted in a single
step, I'd go for

#define pwm_apply_state(pwm, state) pwm_apply_cansleep(pwm, state)

, keep that macro for a while and convert all users step by step. This
way we don't needlessly break oot code and the changes to convert to the
new API can go via their usual trees without time pressure.

> Why not just keep pwm_apply_state() as is and introduce a new
> pwm_apply_state_atomic() for callers which want to apply state
> in a case where sleeping is not allowed ?

There is a big spontaneous growth of function name patterns. I didn't
claim having done a complete research, but not using a suffix for the
fast variant and _cansleep for the sleeping one at least aligns to how
the gpio subsystem names things.

Grepping a bit more:

- regmap has: regmap_might_sleep() and struct regmap::can_sleep
The actual API doesn't have different functions to differentiate
sleeping and non-sleeping calls. (Though there is
regmap_read_poll_timeout_atomic().)

- kmap() + kmap_atomic()
- set_pte() + set_pte_atomic()

- There is scmi_is_transport_atomic() and scmi_handle::is_transport_atomic()
(Is this also about sleeping?)

- There are quite a lot more symbols ending in _atomic and in
_cansleep, but several of them don't exists to differentiate a slow
and a fast procedure. (e.g. drm_mode_atomic)

Not entirely sure what to read out of that.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]