Re: [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

Sam Ravnborg
2024-01-20T13:25:08Z

Hi Dharma & Rob.

> > To make the DT binding backward compatible you likely need to add a few
> > compatible that otherwise would have been left out - but that should do
> > the trick.
> >
> > The current atmel hlcdc driver that is split in three is IMO an
> > over-engineering, and the driver could benefit merging it all in one.
> > And the binding should not prevent this.
>
> I agree on all this, but a conversion is not really the time to redesign
> things. Trust me, I've wanted to on lots of conversions. It should be
> possible to simplify the driver side while keeping the DT as-is. Just
> make the display driver bind to the MFD node instead. After that, then
> one could look at flattening everything to 1 node.

Understood and thinking a bit about it fully agreed as well.
Dharma - please see my comments only as ideas for the future, and
ignore them in this fine rewrite you do.

Sam