Re: [PATCH v14 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

Guenter Roeck
2024-03-07T18:46:50Z

On Wed, Feb 21, 2024 at 06:40:23PM +0800, Billy Tsai wrote:
> From: Naresh Solanki <naresh.solanki@9elements.com>
>
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> $ref: fan-common.yaml#
> unevaluatedProperties: false
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>

Applied to hwmon-next. There have been a couple of questions, specifically:

- min-rpm of 1000 seems low. Fans with higher minimum RPM
are known to exist.
- A default value of '2' was suggested for pulses-per-revolution.

Those questions can be addressed with subsequent patches if needed.

Guenter