Re: [PATCH 2/2] pwm: axi-pwmgen: Make use of regmap_clear_bits()

[Conor Dooley <conor.dooley@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On Mon, Jun 10, 2024 at 10:32:13AM +0200, Uwe Kleine-König wrote:
> On Mon, Jun 10, 2024 at 09:00:53AM +0100, Conor Dooley wrote:
> > On Mon, Jun 10, 2024 at 07:53:33AM +0200, Uwe Kleine-König wrote:
> > > Hello Nuno,
> > > 
> > > On Fri, Jun 07, 2024 at 08:40:32AM +0200, Nuno Sá wrote:
> > > > On Thu, 2024-06-06 at 18:40 +0200, Uwe Kleine-König wrote:
> > > > > Instead of using regmap_update_bits() and passing val=0, better use
> > > > > regmap_clear_bits().
> > > > > 
> > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > > > > ---
> > > > 
> > > > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > > 
> > > Thanks for looking at the patch. When I apply it (using b4) I get
> > > however:
> > > 
> > > NOTE: some trailers ignored due to from/email mismatches:
> > >     ! Trailer: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > >      Msg From: Nuno Sá <noname.nuno@gmail.com>
> > > 
> > > I'll add it anyhow, but it would be great if you fixed your workflow to
> > > have the sender match the address in the tag.
> > 
> > I'm curious, given I do this all the time, do you not see similar issues
> > for me?
> 
> Never noticed that for you. Maybe that's a new check in b4? I recently
> reinstalled my devel machine, so I likely have a new version even if the
> upstream change is a bit older already.

Nah, I think that's been in b4 for as long as I have been using it, even
when I used the old version from debian. Maybe my use of patatt is the
reason or some exemption for kernel.org addresses.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]