Re: [PATCH 01/17] backlight: Add BL_CORE_ constants for power states

[Sam Ravnborg <sam@ravnborg.org>]

Hi Thomas,

On Wed, Jun 12, 2024 at 09:26:11AM +0200, Thomas Zimmermann wrote:
> Hi Sam,
> 
> long time no see.

Had some spare time between jobs, started on my new job last week.
Time will tell if there will be energy and time for hobby stuff.

> > 
> > On top of this - many users of the power states could benefit using the
> > backlight_enable()/backlight_disable() helpers, but that's another story.
> 
> Should I attempt to fix that? Many drivers appear to do something like
> 
>   props.brightness = ...
>   props.power = UNBLANK
>   backlight_update_status()
> 
> That's the same pattern as in backlight_enable().

I would keep the changes at a minimum, hoping someone else jumps in and
do the cleanup. Then you can keep the patches that remove the fbdev
dependency simple and easy to review (and thus get applied).
Maybe the obvious places, and do the simple replacement for the rest..

The drivers initialize and use the backlight properties in interesting
ways so that would require a bit more effort to implement and review.

I did it once for most of drm - but it was buggy so I ended up scrapping
the patches :-(

	Sam