From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, sam@ravnborg.org,
jingoohan1@gmail.com, deller@gmx.de, linus.walleij@linaro.org,
f.suligoi@asem.it, ukleinek@kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-pwm@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 03/17] backlight: ams369fb06: Use backlight power constants
Date: Mon, 24 Jun 2024 17:19:58 +0200 [thread overview]
Message-ID: <20240624152033.25016-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20240624152033.25016-1-tzimmermann@suse.de>
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/backlight/ams369fg06.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c
index 57ec205d2bd2..f8442689ac43 100644
--- a/drivers/video/backlight/ams369fg06.c
+++ b/drivers/video/backlight/ams369fg06.c
@@ -10,7 +10,6 @@
#include <linux/backlight.h>
#include <linux/delay.h>
-#include <linux/fb.h>
#include <linux/lcd.h>
#include <linux/module.h>
#include <linux/spi/spi.h>
@@ -300,7 +299,7 @@ static int ams369fg06_ldi_disable(struct ams369fg06 *lcd)
static int ams369fg06_power_is_on(int power)
{
- return power <= FB_BLANK_NORMAL;
+ return power <= BACKLIGHT_POWER_REDUCED;
}
static int ams369fg06_power_on(struct ams369fg06 *lcd)
@@ -396,8 +395,8 @@ static int ams369fg06_set_power(struct lcd_device *ld, int power)
{
struct ams369fg06 *lcd = lcd_get_data(ld);
- if (power != FB_BLANK_UNBLANK && power != FB_BLANK_POWERDOWN &&
- power != FB_BLANK_NORMAL) {
+ if (power != BACKLIGHT_POWER_ON && power != BACKLIGHT_POWER_OFF &&
+ power != BACKLIGHT_POWER_REDUCED) {
dev_err(lcd->dev, "power value should be 0, 1 or 4.\n");
return -EINVAL;
}
@@ -492,11 +491,11 @@ static int ams369fg06_probe(struct spi_device *spi)
* current lcd status is powerdown and then
* it enables lcd panel.
*/
- lcd->power = FB_BLANK_POWERDOWN;
+ lcd->power = BACKLIGHT_POWER_OFF;
- ams369fg06_power(lcd, FB_BLANK_UNBLANK);
+ ams369fg06_power(lcd, BACKLIGHT_POWER_ON);
} else {
- lcd->power = FB_BLANK_UNBLANK;
+ lcd->power = BACKLIGHT_POWER_ON;
}
spi_set_drvdata(spi, lcd);
@@ -510,7 +509,7 @@ static void ams369fg06_remove(struct spi_device *spi)
{
struct ams369fg06 *lcd = spi_get_drvdata(spi);
- ams369fg06_power(lcd, FB_BLANK_POWERDOWN);
+ ams369fg06_power(lcd, BACKLIGHT_POWER_OFF);
}
#ifdef CONFIG_PM_SLEEP
@@ -524,16 +523,16 @@ static int ams369fg06_suspend(struct device *dev)
* when lcd panel is suspend, lcd panel becomes off
* regardless of status.
*/
- return ams369fg06_power(lcd, FB_BLANK_POWERDOWN);
+ return ams369fg06_power(lcd, BACKLIGHT_POWER_OFF);
}
static int ams369fg06_resume(struct device *dev)
{
struct ams369fg06 *lcd = dev_get_drvdata(dev);
- lcd->power = FB_BLANK_POWERDOWN;
+ lcd->power = BACKLIGHT_POWER_OFF;
- return ams369fg06_power(lcd, FB_BLANK_UNBLANK);
+ return ams369fg06_power(lcd, BACKLIGHT_POWER_ON);
}
#endif
@@ -544,7 +543,7 @@ static void ams369fg06_shutdown(struct spi_device *spi)
{
struct ams369fg06 *lcd = spi_get_drvdata(spi);
- ams369fg06_power(lcd, FB_BLANK_POWERDOWN);
+ ams369fg06_power(lcd, BACKLIGHT_POWER_OFF);
}
static struct spi_driver ams369fg06_driver = {
--
2.45.2
next prev parent reply other threads:[~2024-06-24 15:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 15:19 [PATCH v2 00/17] backlight: Introduce power-state constants Thomas Zimmermann
2024-06-24 15:19 ` [PATCH v2 01/17] backlight: Add BACKLIGHT_POWER_ constants for power states Thomas Zimmermann
2024-06-24 15:19 ` [PATCH v2 02/17] backlight: aat2870-backlight: Use blacklight power constants Thomas Zimmermann
2024-06-24 15:19 ` Thomas Zimmermann [this message]
2024-06-24 15:19 ` [PATCH v2 04/17] backlight: corgi-lcd: Use backlight " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 05/17] backlight: gpio-backlight: " Thomas Zimmermann
2024-06-26 11:52 ` Linus Walleij
2024-06-24 15:20 ` [PATCH v2 06/17] backlight: ipaq-micro-backlight: " Thomas Zimmermann
2024-06-26 11:51 ` Linus Walleij
2024-06-24 15:20 ` [PATCH v2 07/17] backlight: journada_bl: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 08/17] backlight: kb3886-bl: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 09/17] backlight: ktd253-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 10/17] backlight: led-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 11/17] backlight: lm3533-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 12/17] backlight: mp3309c: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 13/17] backlight: pandora-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 14/17] backlight: pcf50633-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 15/17] backlight: pwm-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 16/17] backlight: rave-sp-backlight: " Thomas Zimmermann
2024-06-24 15:20 ` [PATCH v2 17/17] backlight: sky81452-backlight: " Thomas Zimmermann
2024-07-01 11:07 ` [PATCH v2 00/17] backlight: Introduce power-state constants Daniel Thompson
2024-07-04 15:45 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624152033.25016-4-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox