From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: haibo.chen@nxp.com
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-gpio@vger.kernel.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2] dt-bindings: mfd: adp5585: Add parsing of hogs
Date: Wed, 28 Aug 2024 13:58:30 +0300 [thread overview]
Message-ID: <20240828105830.GK30398@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240828030405.2851611-1-haibo.chen@nxp.com>
Hi Haibo,
Thank you for the patch.
On Wed, Aug 28, 2024 at 11:04:05AM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Allow parsing GPIO controller children nodes with GPIO hogs.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
This looks good, sorry for forgetting to add it in the first place.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/mfd/adi,adp5585.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> index f9c069f8534b..ee2272f754a3 100644
> --- a/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> +++ b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> @@ -42,6 +42,13 @@ properties:
> "#pwm-cells":
> const: 3
>
> +patternProperties:
> + "-hog(-[0-9]+)?$":
> + type: object
> +
> + required:
> + - gpio-hog
> +
> required:
> - compatible
> - reg
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-08-28 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:04 [PATCH v2] dt-bindings: mfd: adp5585: Add parsing of hogs haibo.chen
2024-08-28 6:07 ` Krzysztof Kozlowski
2024-08-28 10:58 ` Laurent Pinchart [this message]
2024-08-30 8:24 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828105830.GK30398@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox