From: Florian Fainelli <florian.fainelli@broadcom.com>
To: linux-kernel@vger.kernel.org
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org (open list:PWM SUBSYSTEM),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
BCM7XXX ARM ARCHITECTURE),
justin.chen@broadcom.com
Subject: [PATCH 2/2] pwm: brcmstb: Do not assume open drain configuration
Date: Fri, 11 Oct 2024 19:56:03 -0700 [thread overview]
Message-ID: <20241012025603.1644451-3-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20241012025603.1644451-1-florian.fainelli@broadcom.com>
Read the 'open-drain' property to determine whether the PWM controller
output(s) should be configured in open-drain versus totem pole mode.
Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/pwm/pwm-brcmstb.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
index 0fdeb0b2dbf3..b7cecd36ed57 100644
--- a/drivers/pwm/pwm-brcmstb.c
+++ b/drivers/pwm/pwm-brcmstb.c
@@ -55,6 +55,7 @@ struct brcmstb_pwm {
void __iomem *base;
struct clk *clk;
struct pwm_chip chip;
+ bool open_drain;
};
static inline u32 brcmstb_pwm_readl(struct brcmstb_pwm *p,
@@ -176,6 +177,7 @@ static int brcmstb_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
static inline void brcmstb_pwm_enable_set(struct brcmstb_pwm *p,
unsigned int channel, bool enable)
{
+ u32 oe_mask = p->open_drain ? CTRL_OPENDRAIN : 0;
unsigned int shift = channel * CTRL_CHAN_OFFS;
u32 value;
@@ -183,9 +185,9 @@ static inline void brcmstb_pwm_enable_set(struct brcmstb_pwm *p,
if (enable) {
value &= ~(CTRL_OEB << shift);
- value |= (CTRL_START | CTRL_OPENDRAIN) << shift;
+ value |= (CTRL_START | oe_mask) << shift;
} else {
- value &= ~((CTRL_START | CTRL_OPENDRAIN) << shift);
+ value &= ~((CTRL_START | oe_mask) << shift);
value |= CTRL_OEB << shift;
}
@@ -244,6 +246,7 @@ static int brcmstb_pwm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, p);
+ p->open_drain = device_property_read_bool(&pdev->dev, "open-drain");
p->chip.dev = &pdev->dev;
p->chip.ops = &brcmstb_pwm_ops;
p->chip.npwm = 2;
--
2.34.1
next prev parent reply other threads:[~2024-10-12 3:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 2:56 [PATCH 0/2] pwm: brcmstb: Support configurable open-drain mode Florian Fainelli
2024-10-12 2:56 ` [PATCH 1/2] dt-bindings: pwm: brcm,bcm7038: Document the 'open-drain' property Florian Fainelli
2024-10-15 16:32 ` Rob Herring
2024-10-15 17:07 ` Florian Fainelli
2024-10-29 10:44 ` Uwe Kleine-König
2024-10-29 16:03 ` Florian Fainelli
2024-11-28 11:35 ` Uwe Kleine-König
2024-10-12 2:56 ` Florian Fainelli [this message]
2024-10-14 20:05 ` [PATCH 0/2] pwm: brcmstb: Support configurable open-drain mode Uwe Kleine-König
2024-10-16 7:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012025603.1644451-3-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=justin.chen@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox