From: David Jander <david@protonic.nl>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
"Nuno Sa" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-pwm@vger.kernel.org
Subject: Re: [RFC PATCH 7/7] dt-bindings: motion: Add motion-simple-pwm bindings
Date: Fri, 28 Feb 2025 11:09:31 +0100 [thread overview]
Message-ID: <20250228110931.7bdae7fd@erd003.prtnl> (raw)
In-Reply-To: <9a1d75a2-66c0-46b6-91a1-4922b892dfb1@kernel.org>
On Fri, 28 Feb 2025 10:37:48 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 28/02/2025 10:22, David Jander wrote:
> >
> >>> +
> >>> + motion,pwm-inverted:
> >>> + $ref: /schemas/types.yaml#/definitions/flag
> >>
> >> And PWM flag does not work?
> >
> > I have seen PWM controllers that don't seem to support the
> > PWM_POLARITY_INVERTED flag and those where it just doesn't work. Should all
>
>
> Shouldn't the controllers be fixed? Or let's rephrase the question: why
> only this PWM consumer needs this property and none of others need it?
CCing Uwe Kleine-Koenig and linux-pwm mailing list.
I know that at least in kernel 6.11 the pwm-stm32.c PWM driver doesn't
properly invert the PWM signal when specifying PWM_POLARITY_INVERTED. I agree
this is a probably bug that needs fixing if still present in 6.14-rc. Besides
that, if linux-pwm agrees that every single PWM driver _must_ properly support
this flag, I will drop this consumer flag an start fixing broken PWM drivers
that I encounter. I agree that it makes more sense this way, but I wanted to
be sure.
Best regards,
--
David Jander
next parent reply other threads:[~2025-02-28 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250227162823.3585810-1-david@protonic.nl>
[not found] ` <20250227162823.3585810-8-david@protonic.nl>
[not found] ` <20250228-wonderful-python-of-resistance-d5b662@krzk-bin>
[not found] ` <20250228102201.590b4be6@erd003.prtnl>
[not found] ` <9a1d75a2-66c0-46b6-91a1-4922b892dfb1@kernel.org>
2025-02-28 10:09 ` David Jander [this message]
2025-02-28 15:18 ` [RFC PATCH 7/7] dt-bindings: motion: Add motion-simple-pwm bindings Uwe Kleine-König
2025-03-03 10:53 ` Maud Spierings
2025-03-03 11:40 ` David Jander
2025-03-03 14:18 ` Krzysztof Kozlowski
2025-03-03 16:09 ` David Jander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228110931.7bdae7fd@erd003.prtnl \
--to=david@protonic.nl \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox