From: Lee Jones <lee@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Michael Walle" <mwalle@kernel.org>,
"Bamvor Jian Zhang" <bamv2005@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
Keerthy <j-keerthy@ti.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Pavel Machek" <pavel@kernel.org>,
linux-leds@vger.kernel.org, "kernel test robot" <lkp@intel.com>
Subject: Re: (subset) [PATCH v2 01/15] leds: aw200xx: don't use return with gpiod_set_value() variants
Date: Thu, 13 Mar 2025 15:29:21 +0000 [thread overview]
Message-ID: <20250313152921.GB3645863@google.com> (raw)
In-Reply-To: <CAMRc=MdQcxtXMUCt00=JbGY47cMMWcW8=r3-ZrMKjQkViqnxvA@mail.gmail.com>
On Fri, 07 Mar 2025, Bartosz Golaszewski wrote:
> On Thu, Mar 6, 2025 at 11:51 PM Lee Jones <lee@kernel.org> wrote:
> >
> > On Thu, 20 Feb 2025 10:56:58 +0100, Bartosz Golaszewski wrote:
> > > While gpiod_set_value() currently returns void, it will soon be converted
> > > to return an integer instead. Don't do `return gpiod_set...`.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [01/15] leds: aw200xx: don't use return with gpiod_set_value() variants
> > commit: 5d5e2a6f15a6c5e0c431c1388fd90e14b448da1e
> >
>
> Hi Lee!
>
> Can you please drop it from your tree? You acked v1 of this patch
> after I had already sent v2 (this patch remained unchanged) folded
> into a respin of the bigger GPIO series that had triggered build bots
> to point this issue out in the first place. I picked the entire series
> up and this commit is already in next as
> 129fdfe25ac513018d5fe85b0c493025193ef19f.
Unapplied, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-03-13 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:56 [PATCH v2 00/15] gpiolib: indicate errors in value setters Bartosz Golaszewski
2025-02-20 9:56 ` [PATCH v2 01/15] leds: aw200xx: don't use return with gpiod_set_value() variants Bartosz Golaszewski
2025-03-06 22:51 ` (subset) " Lee Jones
2025-03-07 7:03 ` Bartosz Golaszewski
2025-03-13 15:29 ` Lee Jones [this message]
2025-02-20 9:56 ` [PATCH v2 02/15] gpiolib: make value setters have return values Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 03/15] gpiolib: wrap gpio_chip::set() Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 04/15] gpiolib: rework the wrapper around gpio_chip::set_multiple() Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 05/15] gpiolib: introduce gpio_chip setters that return values Bartosz Golaszewski
2025-02-27 14:00 ` Marek Szyprowski
2025-02-27 14:10 ` Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 06/15] gpio: sim: use value returning setters Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 07/15] gpio: regmap: " Bartosz Golaszewski
2025-02-20 10:08 ` Michael Walle
2025-02-20 9:57 ` [PATCH v2 08/15] gpio: pca953x: " Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 09/15] gpio: mockup: " Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 10/15] gpio: aggregator: " Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 11/15] gpio: max77650: " Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 12/15] gpio: latch: use lock guards Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 13/15] gpio: latch: use value returning setters Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 14/15] gpio: davinci: " Bartosz Golaszewski
2025-02-20 9:57 ` [PATCH v2 15/15] gpio: mvebu: " Bartosz Golaszewski
2025-02-21 9:33 ` [PATCH v2 00/15] gpiolib: indicate errors in value setters Uwe Kleine-König
2025-02-26 10:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313152921.GB3645863@google.com \
--to=lee@kernel.org \
--cc=bamv2005@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mwalle@kernel.org \
--cc=pavel@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox