linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Sá via B4 Relay" <devnull+nuno.sa.analog.com@kernel.org>
To: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-input@vger.kernel.org
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Liu Ying" <victor.liu@nxp.com>
Subject: [PATCH v5 02/20] mfd: adp5585: only add devices given in FW
Date: Sat, 14 Jun 2025 15:35:53 +0100	[thread overview]
Message-ID: <20250614-dev-adp5589-fw-v5-2-7e9d84906268@analog.com> (raw)
In-Reply-To: <20250614-dev-adp5589-fw-v5-0-7e9d84906268@analog.com>

From: Nuno Sá <nuno.sa@analog.com>

Not all devices (features) of the adp5585 device are mandatory to be
used in all platforms. Hence, check what's given in FW and dynamically
create the mfd_cell array to be given to devm_mfd_add_devices().

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/mfd/adp5585.c | 38 +++++++++++++++++++++++++++++---------
 1 file changed, 29 insertions(+), 9 deletions(-)

diff --git a/drivers/mfd/adp5585.c b/drivers/mfd/adp5585.c
index 160e0b38106a6d78f7d4b7c866cb603d96ea673e..53a46734f2d022ec54b3efc2ebbf389357f8d85a 100644
--- a/drivers/mfd/adp5585.c
+++ b/drivers/mfd/adp5585.c
@@ -17,7 +17,13 @@
 #include <linux/regmap.h>
 #include <linux/types.h>
 
-static const struct mfd_cell adp5585_devs[] = {
+enum {
+	ADP5585_DEV_GPIO,
+	ADP5585_DEV_PWM,
+	ADP5585_DEV_MAX
+};
+
+static const struct mfd_cell adp5585_devs[ADP5585_DEV_MAX] = {
 	{ .name = "adp5585-gpio", },
 	{ .name = "adp5585-pwm", },
 };
@@ -110,6 +116,27 @@ static const struct regmap_config adp5585_regmap_configs[] = {
 	},
 };
 
+static int adp5585_add_devices(struct device *dev)
+{
+	int ret;
+
+	if (device_property_present(dev, "#pwm-cells")) {
+		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO,
+					   &adp5585_devs[ADP5585_DEV_PWM], 1, NULL, 0, NULL);
+		if (ret)
+			return dev_err_probe(dev, ret, "Failed to add PWM device\n");
+	}
+
+	if (device_property_present(dev, "#gpio-cells")) {
+		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO,
+					   &adp5585_devs[ADP5585_DEV_GPIO], 1, NULL, 0, NULL);
+		if (ret)
+			return dev_err_probe(dev, ret, "Failed to add GPIO device\n");
+	}
+
+	return 0;
+}
+
 static int adp5585_i2c_probe(struct i2c_client *i2c)
 {
 	const struct regmap_config *regmap_config;
@@ -138,14 +165,7 @@ static int adp5585_i2c_probe(struct i2c_client *i2c)
 		return dev_err_probe(&i2c->dev, -ENODEV,
 				     "Invalid device ID 0x%02x\n", id);
 
-	ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO,
-				   adp5585_devs, ARRAY_SIZE(adp5585_devs),
-				   NULL, 0, NULL);
-	if (ret)
-		return dev_err_probe(&i2c->dev, ret,
-				     "Failed to add child devices\n");
-
-	return 0;
+	return adp5585_add_devices(&i2c->dev);
 }
 
 static int adp5585_suspend(struct device *dev)

-- 
2.49.0



  parent reply	other threads:[~2025-06-14 14:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-14 14:35 [PATCH v5 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 01/20] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá via B4 Relay
2025-06-14 14:35 ` Nuno Sá via B4 Relay [this message]
2025-06-14 14:35 ` [PATCH v5 03/20] mfd: adp5585: enable oscilator during probe Nuno Sá via B4 Relay
2025-06-18 17:41   ` Uwe Kleine-König
2025-06-14 14:35 ` [PATCH v5 04/20] mfd: adp5585: make use of MFD_CELL_NAME() Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 05/20] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 06/20] mfd: adp5585: refactor how regmap defaults are handled Nuno Sá via B4 Relay
2025-06-19 14:19   ` Lee Jones
2025-06-14 14:35 ` [PATCH v5 07/20] mfd: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-06-14 14:35 ` [PATCH v5 08/20] mfd: adp5585: add a per chip reg struture Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 09/20] gpio: adp5585: add support for the adp5589 expander Nuno Sá via B4 Relay
2025-06-16  7:57   ` Bartosz Golaszewski
2025-06-14 14:36 ` [PATCH v5 10/20] pwm: adp5585: add support for adp5589 Nuno Sá via B4 Relay
2025-06-18 17:42   ` Uwe Kleine-König
2025-06-14 14:36 ` [PATCH v5 11/20] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 12/20] mfd: adp5585: add support for event handling Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 13/20] mfd: adp5585: support reset and unlock events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 14/20] mfd: adp5585: add support for input devices Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 15/20] gpio: adp5585: support gpi events Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 16/20] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá via B4 Relay
2025-06-17 21:10   ` Dmitry Torokhov
2025-06-14 14:36 ` [PATCH v5 17/20] Input: adp5589: remove the driver Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 18/20] mfd: adp5585: support getting vdd regulator Nuno Sá via B4 Relay
2025-06-19 14:22   ` Lee Jones
2025-06-14 14:36 ` [PATCH v5 19/20] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá via B4 Relay
2025-06-14 14:36 ` [PATCH v5 20/20] mfd: adp5585: add support for a reset pin Nuno Sá via B4 Relay
2025-06-19 13:38 ` [PATCH v5 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Lee Jones
2025-06-27 15:46   ` Nuno Sá
2025-07-01 11:05     ` Lee Jones
2025-07-01 11:09       ` Nuno Sá
2025-07-01 11:15         ` Krzysztof Kozlowski
2025-07-01 11:19         ` Laurent Pinchart
2025-07-01 13:37           ` Lee Jones
2025-07-01 13:42             ` Nuno Sá
2025-06-19 14:23 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250614-dev-adp5589-fw-v5-2-7e9d84906268@analog.com \
    --to=devnull+nuno.sa.analog.com@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).