From: Andreas Kemnade <andreas@kemnade.info>
To: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Cc: lee@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org, ukleinek@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x
Date: Wed, 3 Sep 2025 00:08:04 +0200 [thread overview]
Message-ID: <20250903000804.689a0a06@akair> (raw)
In-Reply-To: <20250902212921.89759-1-jihed.chaibi.dev@gmail.com>
Am Tue, 2 Sep 2025 23:29:21 +0200
schrieb Jihed Chaibi <jihed.chaibi.dev@gmail.com>:
[...]
> + be paired with a generic fallback (generally for power
saving mode).
> + additionalProperties: false
> + properties:
> + compatible:
> + oneOf:
> + - enum:
> + - ti,twl4030-power
> + - ti,twl4030-power-reset
> + - ti,twl4030-power-idle
> + - ti,twl4030-power-idle-osc-off
> + # Add all board-specific compatibles for completeness
> + - ti,twl4030-power-omap3-sdp
> + - ti,twl4030-power-omap3-ldp
> + - ti,twl4030-power-omap3-evm
> + - ti,twl4030-power-beagleboard-xm
> + - ti,twl4030-power-n900
> + - items:
> + - enum:
> + - ti,twl4030-power
> + - ti,twl4030-power-reset
> + - ti,twl4030-power-idle
> + - ti,twl4030-power-idle-osc-off
> + # Add all board-specific compatibles for completeness
> + - ti,twl4030-power-omap3-sdp
> + - ti,twl4030-power-omap3-ldp
> + - ti,twl4030-power-omap3-evm
> + - ti,twl4030-power-beagleboard-xm
> + - ti,twl4030-power-n900
> + - enum:
> + # Fallback (for power saving mode)
> + - ti,twl4030-power-idle
> + - ti,twl4030-power-idle-osc-off
this allows quite weird combinations like
"ti,twl4030-power-idle", "ti,twl4030-power-idle".
I would propose to rather clean this up to things used in
twl4030-power.c and at the same time available in dts, also
taking the brush in the dts. I do not expect that these specific
compatibles are in use anywhere. I looked around earlier.
Regards,
Andreas
next prev parent reply other threads:[~2025-09-02 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 21:29 [PATCH v5] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x Jihed Chaibi
2025-09-02 22:08 ` Andreas Kemnade [this message]
2025-09-02 22:55 ` Jihed Chaibi
2025-09-03 14:46 ` Andreas Kemnade
2025-09-03 16:57 ` Rob Herring
2025-09-03 17:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903000804.689a0a06@akair \
--to=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jihed.chaibi.dev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shuah@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox