From: Andreas Kemnade <andreas@kemnade.info>
To: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Cc: robh@kernel.org, lee@kernel.org, krzk+dt@kernel.org,
tony@atomide.com, conor+dt@kernel.org, ukleinek@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x
Date: Tue, 9 Sep 2025 19:13:00 +0200 [thread overview]
Message-ID: <20250909191300.03ba06e0@akair> (raw)
In-Reply-To: <20250906145905.93845-2-jihed.chaibi.dev@gmail.com>
Am Sat, 6 Sep 2025 16:59:03 +0200
schrieb Jihed Chaibi <jihed.chaibi.dev@gmail.com>:
[...]
> @@ -181,28 +194,189 @@ properties:
> "#clock-cells":
> const: 1
>
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: fck
> +
> charger:
> type: object
> additionalProperties: true
> +
> properties:
> compatible: true
> +
> required:
> - compatible
>
> rtc:
> type: object
> additionalProperties: false
> +
> properties:
> compatible:
> const: ti,twl4030-rtc
> interrupts:
> maxItems: 1
>
> + audio:
> + type: object
> + additionalProperties: true
> +
> + properties:
> + compatible:
> + const: ti,twl4030-audio
> +
> + required:
> + - compatible
> +
hmm, twl6030/32 have no audio, but it is in the common part with no
false in the if: part
> + keypad:
> + type: object
> + additionalProperties: true
> +
> + properties:
> + compatible:
> + const: ti,twl4030-keypad
> +
> + required:
> + - compatible
> +
same here and in more places. So if we do not want this old stuff to be
that precise and just have dtbs_check clean and this nightmare of a
conversion finished, then it might be fine.
Regards,
Andreas
next prev parent reply other threads:[~2025-09-09 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 14:59 [PATCH v6 0/3] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x Jihed Chaibi
2025-09-06 14:59 ` [PATCH v6 1/3] " Jihed Chaibi
2025-09-09 8:36 ` Uwe Kleine-König
2025-09-09 16:43 ` Rob Herring (Arm)
2025-09-09 17:13 ` Andreas Kemnade [this message]
2025-09-06 14:59 ` [PATCH v6 2/3] ARM: dts: omap3: beagle-xm: Correct obsolete TWL4030 power compatible Jihed Chaibi
2025-09-06 14:59 ` [PATCH v6 3/3] ARM: dts: omap3: n900: " Jihed Chaibi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909191300.03ba06e0@akair \
--to=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jihed.chaibi.dev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox