Re: [PATCH v4 00/20] Samsung PWM support cleanup

[Tomasz Figa <tomasz.figa@gmail.com>]

On Monday 22 of July 2013 11:01:32 Kukjin Kim wrote:
> Kukjin Kim wrote:
> > Tomasz Figa wrote:
> > > On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote:
> > > > On 07/20/2013 02:04 AM, Tomasz Figa wrote:
> > > > > Since we now have a proper Samsung PWM clocksource driver in
> > > > > place,
> > > > > we can proceed with further cleanup of PWM timers support on
> > > > > Samsung
> > > > > SoCs.>
> > > > > 
> > > > > This series attempts to achieve this goal by:
> > > > >   1) fixing up few things in samsung_pwm_timer clocksource
> > > > >   driver,
> > > > >   2) moving remaining Samsung platforms to the new clocksource
> > 
> > driver,
> > 
> > > > >   3) removing old clocksource driver,
> > > > >   4) adding new multiplatform- and DT-aware PWM driver,
> > > > >   5) moving all Samsung platforms to use the new PWM driver,
> > > > >   6) removing old PWM driver,
> > > > >   7) removing all PWM-related code that is not used anymore.
> > > > > 
> > > > > Cleaning up the PWM driver is a bit tricky, because the design
> > > > > of
> > > > > current driver makes it completely unsuitable for DT and
> > > > > multiplatform and would require a heavy rework to make it
> > > > > usable,
> > > > > breaking any existing Samsung PWM users by the way. To avoid any
> > > > > breakage this series first renames the old driver, then adds new
> > > > > one
> > > > > using original name, migrates all platforms to use it and then
> > > > > finally removes the old driver.
> > > > > 
> > > > > See particular patches for more detailed descriptions.
> > > > > 
> > > > > [On S3C6410-based Tiny6410 (Mini6410-compatible) with
> > > > > pwm-beeper,
> > > > > SMDK6410 with PWM backlight and Exynos4210-based Origen board
> > > > > (with
> > > > > PWM0 attached to a scope)]
> > > > > Tested-by: Tomasz Figa<tomasz.figa@gmail.com>
> > > > > 
> > > > > [On S3C2440-based Mini2440 board]
> > > > > Tested-by: Sylwester Nawrocki<sylvester.nawrocki@gmail.com>
> > > > 
> > > > I have retested this series on top of v3.11-rc1 with pwm-backlight
> > 
> > (and
> > 
> > > > buzzer
> > > > as the output :)) on Mini2440. It seems to work well - generated
> > > > frequencies are correct. I'll check pulse widths with a scope
> 
> tomorrow,
> 
> > > > as it's a bit late
> > > > now. FWIW you can add to this series my:
> > > > 
> > > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > > 
> > > Thanks. I hope we can finally get this series merged soon.
> > 
> > Yes, this whole patches look good to me, and I'd like to take this
> > whole patches into the samsung tree...but need to get any response
> > from PWM guy, Thierry Reding. Let's wait for his response...
> 
> To be clarify, because his ack was on v3 and I remember he had a
> comment. So would be better if we could get his ack on pwm change
> again.

Sure.

Best regards,
Tomasz