From: "Xuyang Dong" <dongxuyang@eswincomputing.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ben-linux@fluff.org,
ben.dooks@codethink.co.uk, p.zabel@pengutronix.de,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, xuxiang@eswincomputing.com,
wangguosheng@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: Re: [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property
Date: Wed, 10 Jun 2026 17:25:20 +0800 (GMT+08:00) [thread overview]
Message-ID: <25b0baf0.731a.19eb0d9bf07.Coremail.dongxuyang@eswincomputing.com> (raw)
In-Reply-To: <c4fa85f1-365e-49ab-9549-d6d46529a68b@kernel.org>
>
> On 09/06/2026 11:31, Xuyang Dong wrote:
> >>>
> >>> EIC7700 use DesignWare IP for PWM controllers. Add ESWIN EIC7700 support
> >>> in snps,dw-apb-timers-pwm2.yaml.
> >>>
> >>> The DesignWare PWM includes separate reset signals dedicated to each clock
> >>> domain:
> >>> The presetn signal resets logic in pclk domain.
> >>> The timer_N_resetn signal resets logic in the timer_N_clk domain.
> >>> The resets are active-low.
> >>>
> >>> The generic snps,dw-apb-timers-pwm2 binding allows one or two optional
> >>
> >> I don't know what is the generic binding, but it does not allow. Open
> >> the file: there are no resets at all, so it does not allow them. Or you
> >> mixed tenses here and you wanted to describe the change?
> >>
> >
> > Hi Krzysztof,
> >
> > Thanks for your comments and time.
> >
> > Regarding snps,dw-apb-timers-pwm2, we previously intended to add the
> > resets property in the same patch.
> > However, as you suggested, we will split it into a separate patch.
>
> I find commit msg still confusing. Please always clearly explain WHY you
> are doing changes.
>
Hi Krzysztof,
Thanks for your comments.
According to the DesignWare IP for PWM controllers manual, it seems to me
that Ben's previous submission may have missed the optional resets property.
Therefore, I would like to confirm: should I submit a separate fix patch for
the resets property, or include it as a feature patch in this series?
Best regards,
Xuyang Dong
next prev parent reply other threads:[~2026-06-10 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 8:22 [PATCH v7 0/2] Update designware pwm driver dongxuyang
2026-06-05 8:23 ` [PATCH v7 1/2] dt-bindings: pwm: dwc: Add eswin compatible and resets property dongxuyang
2026-06-05 10:12 ` Krzysztof Kozlowski
2026-06-09 9:31 ` Xuyang Dong
2026-06-09 10:02 ` Krzysztof Kozlowski
2026-06-10 9:25 ` Xuyang Dong [this message]
2026-06-10 10:17 ` Krzysztof Kozlowski
2026-06-05 8:24 ` [PATCH v7 2/2] pwm: dwc: add of/platform support Xuyang Dong
[not found] ` <20260605083829.60F021F00893@smtp.kernel.org>
2026-06-12 9:30 ` Xuyang Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b0baf0.731a.19eb0d9bf07.Coremail.dongxuyang@eswincomputing.com \
--to=dongxuyang@eswincomputing.com \
--cc=ben-linux@fluff.org \
--cc=ben.dooks@codethink.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=wangguosheng@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox