From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: "Trevor Gamblin" <tgamblin@baylibre.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: axi-pwmgen: Make use of regmap_clear_bits()
Date: Mon, 10 Jun 2024 10:10:44 +0200 [thread overview]
Message-ID: <28680a1c88a680fc03de9256c14f2553386c8190.camel@gmail.com> (raw)
In-Reply-To: <no6gyqovcjrzcior5lym6qtb7ya4abgcspe2mebpvfc2bl3f4i@h3x64l7pomhf>
On Mon, 2024-06-10 at 07:53 +0200, Uwe Kleine-König wrote:
> Hello Nuno,
>
> On Fri, Jun 07, 2024 at 08:40:32AM +0200, Nuno Sá wrote:
> > On Thu, 2024-06-06 at 18:40 +0200, Uwe Kleine-König wrote:
> > > Instead of using regmap_update_bits() and passing val=0, better use
> > > regmap_clear_bits().
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > > ---
> >
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> Thanks for looking at the patch. When I apply it (using b4) I get
> however:
>
> NOTE: some trailers ignored due to from/email mismatches:
> ! Trailer: Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Msg From: Nuno Sá <noname.nuno@gmail.com>
>
> I'll add it anyhow, but it would be great if you fixed your workflow to
> have the sender match the address in the tag.
>
Yeah, I'm aware of it. Sending emails from my corporate email is just too
painful that I use my personal one and an email client that actually fits kernel
development. Til now, it was never an issue and this is the first "complain" I'm
getting :). I'll try to remember this for pwm in the future...
Sorry for the trouble!
- Nuno Sá
prev parent reply other threads:[~2024-06-10 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 16:40 [PATCH 0/2] pwm: Make use of regmap_{set,clear}_bits() Uwe Kleine-König
2024-06-06 16:40 ` [PATCH 1/2] pwm: jz4740: Another few conversions to regmap_{set,clear}_bits() Uwe Kleine-König
2024-06-07 16:21 ` Paul Cercueil
2024-06-06 16:40 ` [PATCH 2/2] pwm: axi-pwmgen: Make use of regmap_clear_bits() Uwe Kleine-König
2024-06-06 17:09 ` Trevor Gamblin
2024-06-07 6:40 ` Nuno Sá
2024-06-10 5:53 ` Uwe Kleine-König
2024-06-10 8:00 ` Conor Dooley
2024-06-10 8:32 ` Uwe Kleine-König
2024-06-10 9:25 ` Conor Dooley
2024-06-10 8:10 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28680a1c88a680fc03de9256c14f2553386c8190.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=linux-pwm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=tgamblin@baylibre.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).