From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code Date: Mon, 1 Apr 2019 13:15:23 +0530 Message-ID: <3379a7a9-64d4-7892-0f40-3d437a24e0f6@codeaurora.org> References: <1554095960-15638-1-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1554095960-15638-1-git-send-email-Anson.Huang@nxp.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang , "thierry.reding@gmail.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-pwm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Cc: dl-linux-imx List-Id: linux-pwm@vger.kernel.org On 4/1/2019 10:54 AM, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/pwm/pwm-imx27.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c > index 8061306..434a351 100644 > --- a/drivers/pwm/pwm-imx27.c > +++ b/drivers/pwm/pwm-imx27.c > @@ -291,7 +291,6 @@ MODULE_DEVICE_TABLE(of, pwm_imx27_dt_ids); > static int pwm_imx27_probe(struct platform_device *pdev) > { > struct pwm_imx27_chip *imx; > - struct resource *r; > > imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL); > if (imx == NULL) > @@ -326,8 +325,7 @@ static int pwm_imx27_probe(struct platform_device *pdev) > imx->chip.of_xlate = of_pwm_xlate_with_flags; > imx->chip.of_pwm_n_cells = 3; > > - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - imx->mmio_base = devm_ioremap_resource(&pdev->dev, r); > + imx->mmio_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(imx->mmio_base)) > return PTR_ERR(imx->mmio_base); >