From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-pwm@vger.kernel.org, ukleinek@kernel.org,
lorenzo.bianconi83@gmail.com, krzk+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, upstream@airoha.com,
angelogioacchino.delregno@collabora.com,
benjamin.larsson@genexis.eu, conor+dt@kernel.org,
ansuelsmth@gmail.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM
Date: Mon, 12 Aug 2024 15:26:46 +0200 [thread overview]
Message-ID: <37564d7f-a189-476b-b6d9-386f044c88a3@kernel.org> (raw)
In-Reply-To: <Zrncq1a_TuZLXLZ9@lore-rh-laptop.homenet.telecomitalia.it>
On 12/08/2024 11:58, Lorenzo Bianconi wrote:
>> On 11/08/2024 18:34, Lorenzo Bianconi wrote:
>>> From: Christian Marangi <ansuelsmth@gmail.com>
>>>
>>> Document required property for the Airoha EN7581 PWM. The device
>>> requires 3 different address for the sgpio, flash and cycle config.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> That's odd placement. Which tool placed it that way?
>
> I placed it manually. Do you prefer to put the Reviewed-by tag at the end if
> the patch is unchanged?
Please do not place tags manually unless you carefully follow submitting
patches and DCO process. Use b4 for this.
Tag must be moved further, because here it is placed incorrectly.
Christian did not send this patch after receiving my review. I did not
review it before he wrote it, either.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-12 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 16:34 [PATCH v2 0/2] Add PWM support to EN7581 Lorenzo Bianconi
2024-08-11 16:34 ` [PATCH v2 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM Lorenzo Bianconi
2024-08-12 9:23 ` Krzysztof Kozlowski
2024-08-12 9:58 ` Lorenzo Bianconi
2024-08-12 13:26 ` Krzysztof Kozlowski [this message]
2024-08-11 16:34 ` [PATCH v2 2/2] pwm: airoha: Add support for EN7581 SoC Lorenzo Bianconi
2024-08-12 9:42 ` kernel test robot
2024-08-12 14:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37564d7f-a189-476b-b6d9-386f044c88a3@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox