From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D74DC001B0 for ; Fri, 7 Jul 2023 08:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232786AbjGGITQ convert rfc822-to-8bit (ORCPT ); Fri, 7 Jul 2023 04:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232740AbjGGITP (ORCPT ); Fri, 7 Jul 2023 04:19:15 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C892C1FC4 for ; Fri, 7 Jul 2023 01:19:14 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHgg8-0000hE-1u; Fri, 07 Jul 2023 10:19:00 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qHgg5-00Cgor-M5; Fri, 07 Jul 2023 10:18:57 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1qHgg5-0002o2-13; Fri, 07 Jul 2023 10:18:57 +0200 Message-ID: <38ffed42bb021ea75bc662edd943a8e4ca92172b.camel@pengutronix.de> Subject: Re: [PATCH v3 2/3] pwm: Add Allwinner's D1/T113-S3/R329 SoCs PWM support From: Philipp Zabel To: Aleksandr Shubin , linux-kernel@vger.kernel.org Cc: Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Cristian Ciocaltea , Greg Kroah-Hartman , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org Date: Fri, 07 Jul 2023 10:18:57 +0200 In-Reply-To: <20230627082334.1253020-3-privatesub2@gmail.com> References: <20230627082334.1253020-1-privatesub2@gmail.com> <20230627082334.1253020-3-privatesub2@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pwm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Di, 2023-06-27 at 11:23 +0300, Aleksandr Shubin wrote: [...] > +static int sun20i_pwm_probe(struct platform_device *pdev) > +{ [...] > + sun20i_chip->rst = devm_reset_control_get(&pdev->dev, NULL); Please use devm_reset_control_get_exclusive() directly. regards Philipp