[PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format

[PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format

[Frank Li]

Convert lpc1850-sct-pwm.txt to yaml format.

Additional changes:
- add ref pwm.yaml.
- add resets property to match existed dts.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/pwm/lpc1850-sct-pwm.txt          | 20 --------
 .../bindings/pwm/nxp,lpc1850-sct-pwm.yaml     | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pwm/lpc1850-sct-pwm.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc1850-sct-pwm.yaml

diff --git a/Documentation/devicetree/bindings/pwm/lpc1850-sct-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc1850-sct-pwm.txt
deleted file mode 100644
index 43d9f4f08a2e2..0000000000000
--- a/Documentation/devicetree/bindings/pwm/lpc1850-sct-pwm.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-* NXP LPC18xx State Configurable Timer - Pulse Width Modulator driver
-
-Required properties:
-  - compatible: Should be "nxp,lpc1850-sct-pwm"
-  - reg: Should contain physical base address and length of pwm registers.
-  - clocks: Must contain an entry for each entry in clock-names.
-    See ../clock/clock-bindings.txt for details.
-  - clock-names: Must include the following entries.
-    - pwm: PWM operating clock.
-  - #pwm-cells: Should be 3. See pwm.yaml in this directory for the description
-    of the cells format.
-
-Example:
-  pwm: pwm@40000000 {
-    compatible = "nxp,lpc1850-sct-pwm";
-    reg = <0x40000000 0x1000>;
-    clocks =<&ccu1 CLK_CPU_SCT>;
-    clock-names = "pwm";
-    #pwm-cells = <3>;
-  };
diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc1850-sct-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc1850-sct-pwm.yaml
new file mode 100644
index 0000000000000..b524978695979
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/nxp,lpc1850-sct-pwm.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/nxp,lpc1850-sct-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP LPC18xx State Configurable Timer
+
+maintainers:
+  - Frank Li <Frank.Li@nxp.com>
+
+properties:
+  compatible:
+    const: nxp,lpc1850-sct-pwm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: pwm
+
+  resets:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - '#pwm-cells'
+
+allOf:
+  - $ref: pwm.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/lpc18xx-ccu.h>
+
+    pwm@40000000 {
+        compatible = "nxp,lpc1850-sct-pwm";
+        reg = <0x40000000 0x1000>;
+        clocks =<&ccu1 CLK_CPU_SCT>;
+        clock-names = "pwm";
+        #pwm-cells = <3>;
+    };
-- 
2.34.1

Re: [PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format

[Rob Herring (Arm)]

On Mon, 02 Jun 2025 10:07:21 -0400, Frank Li wrote:
> Convert lpc1850-sct-pwm.txt to yaml format.
> 
> Additional changes:
> - add ref pwm.yaml.
> - add resets property to match existed dts.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../bindings/pwm/lpc1850-sct-pwm.txt          | 20 --------
>  .../bindings/pwm/nxp,lpc1850-sct-pwm.yaml     | 51 +++++++++++++++++++
>  2 files changed, 51 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pwm/lpc1850-sct-pwm.txt
>  create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc1850-sct-pwm.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hello Frank,

On Mon, Jun 02, 2025 at 10:07:21AM -0400, Frank Li wrote:
> +properties:
> +  compatible:
> +    const: nxp,lpc1850-sct-pwm
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: pwm
> +
> +  resets:
> +    maxItems: 1

Please add:

  '#pwm-cells':
    const: 3

Otherwise looks fine.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/1] dt-bindings: pwm: convert lpc1850-sct-pwm.txt to yaml format

[Vladimir Zapolskiy]

On 6/16/25 16:40, Uwe Kleine-König wrote:
> Hello Frank,
> 
> On Mon, Jun 02, 2025 at 10:07:21AM -0400, Frank Li wrote:
>> +properties:
>> +  compatible:
>> +    const: nxp,lpc1850-sct-pwm
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    items:
>> +      - const: pwm
>> +
>> +  resets:
>> +    maxItems: 1
> 
> Please add:
> 
>    '#pwm-cells':
>      const: 3
> 
> Otherwise looks fine.
> 

With the requested change applied, please add

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir