From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set Date: Thu, 05 Jan 2017 22:42:16 +0100 Message-ID: <4225650.R96pl5clWf@wuerfel> References: <20170105210158.14204-1-afd@ti.com> <20170105210158.14204-7-afd@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170105210158.14204-7-afd-l0cyMroinI0@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Cc: "Andrew F. Davis" , Russell King , Miguel Ojeda Sandonis , Wolfram Sang , Richard Purdie , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Ulf Hansson , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Ingo Molnar , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pwm@vger.kernel.org On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote: > @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/ > obj-$(CONFIG_GAMEPORT) += input/gameport/ > obj-$(CONFIG_INPUT) += input/ > obj-$(CONFIG_RTC_LIB) += rtc/ > -obj-y += i2c/ media/ > +obj-y += i2c/ > +obj-$(CONFIG_MEDIA_SUPPORT) += media/ > obj-$(CONFIG_PPS) += pps/ > obj-y += ptp/ > obj-$(CONFIG_W1) += w1/ > This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers inside of drivers/media/ are built-in, we will fail to enter the directory, see drivers/media/Makefile. I checked the other five patches in the series as well, they all look ok to me. Arnd