From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms@verge.net.au>
Cc: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
geert@glider.be, linux-pwm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement
Date: Fri, 12 May 2017 13:00:34 +0300 [thread overview]
Message-ID: <4398514.qBghdda7X5@avalon> (raw)
In-Reply-To: <20170512091636.GG27979@verge.net.au>
Hi Simon,
On Friday 12 May 2017 11:16:39 Simon Horman wrote:
> On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> > Hi!
> >
> > Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> > boards.
> >
> > This revision addresses the issues found by Geert and adds Laurent's
> > backlight support patch, including a version for r8a7796.
> >
> > CU
> > Uli
> >
> > Changes since v1:
> > - PWM clock is S0D12, not S3D4
> > - dts: fix register lengths, add resets
> > - only enable one set of pins for each PWM
> > - add backlight support
> >
> > Laurent Pinchart (1):
> > arm64: dts: r8a7795: salvator-x: Add panel backlight support
> >
> > Ryo Kodama (2):
> > clk: renesas: r8a7796: add PWM clock
> > arm64: dts: r8a7796-salvator-x: Add PWM device support
> >
> > Takeshi Kihara (3):
> > pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
> > arm64: dts: r8a7796: Add PWM device nodes
> > arm64: dts: r8a7795-salvator-x: Enable PWM2
>
> I did not notice any regressions on salvator-x/r8a7796 after applying up
> the dts patches without the clk and pinctrl patches. So I have queued up
> the dts patches as follows:
>
> * arm64: dts: r8a7796: Add PWM device nodes
> -> applied
>
> * arm64: dts: r8a7795: salvator-x: Add panel backlight support
> * arm64: dts: r8a7795-salvator-x: Enable PWM2
I've asked Ulrich for a clarification on this patch as I'm not sure it's
needed, but he hasn't answered yet. Could we delay merging it until the
situation is clarified ?
All other patches in this series should be fine.
> -> applied to salvator-x.dtsi instead of r8a7796-salvator-x.dts
>
> * arm64: dts: r8a7796: salvator-x: Add panel backlight support
> * arm64: dts: r8a7796-salvator-x: Add PWM device support
> -> not applied as they would be the same changes as those above
> applied to salvator-x.dtsi
>
> > Ulrich Hecht (2):
> > arm64: dts: r8a7796: salvator-x: Add panel backlight support
> > dt-bindings: pwm: Add R-Car M3-W device tree bindings
>
> I took the liberty of reposting the dt-bindings patch with an updated To/Cc
> list.
>
> > .../devicetree/bindings/pwm/renesas,pwm-rcar.txt | 1 +
> > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 34 +++++
> > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 35 +++++
> > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 70 ++++++++++
> > drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
> > drivers/pinctrl/sh-pfc/pfc-r8a7796.c | 153 ++++++++++++++++
> > 6 files changed, 294 insertions(+)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-05-12 10:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 14:37 [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 1/8] pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 2/8] clk: renesas: r8a7796: add PWM clock Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 3/8] arm64: dts: r8a7796: Add PWM device nodes Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 4/8] arm64: dts: r8a7796: salvator-x: Add panel backlight support Ulrich Hecht
2017-04-27 14:43 ` Laurent Pinchart
2017-05-13 18:56 ` Laurent Pinchart
2017-05-15 5:48 ` Simon Horman
2017-05-15 6:50 ` Laurent Pinchart
2017-05-15 6:59 ` Simon Horman
2017-09-05 15:08 ` Geert Uytterhoeven
2017-04-27 14:37 ` [PATCH v2 5/8] arm64: dts: r8a7796-salvator-x: Add PWM device support Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support Ulrich Hecht
2017-04-27 14:42 ` Laurent Pinchart
2017-04-27 14:43 ` Laurent Pinchart
2017-04-28 5:23 ` Simon Horman
2017-04-27 14:37 ` [PATCH v2 7/8] arm64: dts: r8a7795-salvator-x: Enable PWM2 Ulrich Hecht
2017-04-27 14:40 ` Laurent Pinchart
2017-08-30 8:06 ` Simon Horman
2017-08-30 8:08 ` Simon Horman
2017-04-27 14:37 ` [PATCH v2 8/8] dt-bindings: pwm: Add R-Car M3-W device tree bindings Ulrich Hecht
2017-04-27 14:50 ` Geert Uytterhoeven
2017-04-28 5:24 ` Simon Horman
2017-04-28 7:29 ` [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement Simon Horman
2017-05-12 9:16 ` Simon Horman
2017-05-12 10:00 ` Laurent Pinchart [this message]
2017-05-12 10:36 ` Ulrich Hecht
2017-05-12 11:03 ` Laurent Pinchart
2017-05-15 5:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4398514.qBghdda7X5@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@glider.be \
--cc=horms@verge.net.au \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).