Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-leds@vger.kernel.org, linux-pwm@vger.kernel.org,
	kernel@pengutronix.de, Rogan Dawes <rogan@dawes.za.net>
Subject: Re: [PATCH] leds: pwm: Don't disable the PWM when the LED should be off
Date: Fri, 22 Sep 2023 12:59:06 -0300	[thread overview]
Message-ID: <4b5874469878821a7144fb85f143a88d@denx.de> (raw)
In-Reply-To: <20230922142304.1685985-1-u.kleine-koenig@pengutronix.de>

Hi Uwe,

On 22/09/2023 11:23, Uwe Kleine-König wrote:

>  	led_dat->pwmstate.duty_cycle = duty;
> -	led_dat->pwmstate.enabled = duty > 0;
> +	led_dat->pwmstate.enabled = 1;

Thanks for the fix.

Nit: I would suggest:

led_dat->pwmstate.enabled = true;

Reviewed-by: Fabio Estevam <festevam@denx.de>

      reply	other threads:[~2023-09-22 15:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 14:23 [PATCH] leds: pwm: Don't disable the PWM when the LED should be off Uwe Kleine-König
2023-09-22 15:59 ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b5874469878821a7144fb85f143a88d@denx.de \
    --to=festevam@denx.de \
    --cc=kernel@pengutronix.de \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rogan@dawes.za.net \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox