From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>, linux-pwm@vger.kernel.org
Cc: ukleinek@kernel.org, lorenzo.bianconi83@gmail.com,
krzk+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, upstream@airoha.com,
angelogioacchino.delregno@collabora.com,
benjamin.larsson@genexis.eu, conor+dt@kernel.org,
ansuelsmth@gmail.com
Subject: Re: [PATCH 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM
Date: Sat, 10 Aug 2024 13:36:04 +0200 [thread overview]
Message-ID: <4c63b64b-b6f2-4e72-95c5-5555681f6d10@kernel.org> (raw)
In-Reply-To: <6a95b1d7fb90045a51a0cf51b9fafff26790904b.1723264979.git.lorenzo@kernel.org>
On 10/08/2024 06:48, Lorenzo Bianconi wrote:
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pwm@1fbf0224 {
> + compatible = "airoha,en7581-pwm";
> + reg = <0x1fbf0224 0x10>,
> + <0x1fbf0238 0x28>,
> + <0x1fbf0298 0x8>;
These look almost continuous, so I wonder what's in between? E.g.
between 0x1fbf0224+10=0x1fbf0234 and 0x1fbf0238?
Rest looks good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-10 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 4:48 [PATCH 0/2] Add PWM support to EN7581 Lorenzo Bianconi
2024-08-10 4:48 ` [PATCH 1/2] dt-bindings: pwm: Document Airoha EN7581 PWM Lorenzo Bianconi
2024-08-10 11:36 ` Krzysztof Kozlowski [this message]
2024-08-10 17:18 ` Lorenzo Bianconi
2024-08-11 12:26 ` Krzysztof Kozlowski
2024-08-10 4:48 ` [PATCH 2/2] pwm: airoha: Add support for EN7581 SoC Lorenzo Bianconi
2024-08-10 11:34 ` Krzysztof Kozlowski
2024-08-10 17:02 ` Lorenzo Bianconi
2024-08-10 19:35 ` kernel test robot
2024-08-11 1:15 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c63b64b-b6f2-4e72-95c5-5555681f6d10@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lorenzo@kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox