From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Wenhua Lin" <Wenhua.Lin@unisoc.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
wenhua lin <wenhua.lin1994@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
zhaochen su <zhaochen.su29@gmail.com>,
Zhaochen Su <Zhaochen.Su@unisoc.com>,
Xiaolong Wang <Xiaolong.Wang@unisoc.com>
Subject: Re: [PATCH 2/6] pwm: sprd: Improve the pwm backlight control function
Date: Mon, 22 Jan 2024 16:46:34 +0100 [thread overview]
Message-ID: <4e3ee39f-2cad-4543-a505-8b0d16a01ad6@kernel.org> (raw)
In-Reply-To: <20240122081754.17058-3-Wenhua.Lin@unisoc.com>
On 22/01/2024 09:17, Wenhua Lin wrote:
> +
> static int sprd_pwm_probe(struct platform_device *pdev)
> {
> struct sprd_pwm_chip *spc;
> @@ -288,6 +310,10 @@ static int sprd_pwm_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> + ret = sprd_pwm_get_mod(pdev);
> + if (ret)
> + dev_err(&pdev->dev, "get pwm mod failed! Use default setting\n");
That's not an error. dev_info. Assuming that it will even stay (once you
send proper version for proper review).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-22 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:17 [PATCH 0/6] pwm: sprd: Modification of UNISOC Platform PWM Driver Wenhua Lin
2024-01-22 8:17 ` [PATCH 1/6] pwm: sprd: Add support for UMS9620 Wenhua Lin
2024-01-26 7:19 ` Uwe Kleine-König
2024-01-22 8:17 ` [PATCH 2/6] pwm: sprd: Improve the pwm backlight control function Wenhua Lin
2024-01-22 15:46 ` Krzysztof Kozlowski [this message]
2024-01-22 8:17 ` [PATCH 3/6] pwm: sprd: Optimize the calculation method of duty Wenhua Lin
2024-01-22 8:17 ` [PATCH 4/6] dt-bindings: pwm: sprd: Convert to YAML Wenhua Lin
2024-01-22 15:44 ` Krzysztof Kozlowski
2024-01-22 8:17 ` [PATCH 5/6] pwm: sprd: Add sprd,ums9620-pwm compatible Wenhua Lin
2024-01-22 15:45 ` Krzysztof Kozlowski
2024-01-22 8:17 ` [PATCH 6/6] dt-bindings: pwm: sprd: Add sprd,mod attribute Wenhua Lin
2024-01-22 15:45 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e3ee39f-2cad-4543-a505-8b0d16a01ad6@kernel.org \
--to=krzk@kernel.org \
--cc=Wenhua.Lin@unisoc.com \
--cc=Xiaolong.Wang@unisoc.com \
--cc=Zhaochen.Su@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhaochen.su29@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox