Re: [PATCH 1/3] dt-bindings: iio: dac: Add binding for AD5706R

Krzysztof Kozlowski
2026-02-21T10:45:47Z

On Fri, Feb 20, 2026 at 04:02:56PM +0800, Alexis Czezar Torreno wrote:
> Add device tree binding documentation for the Analog Devices
> AD5706R 4-channel 16-bit current output digital-to-analog converter.

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
> ---
> .../devicetree/bindings/iio/dac/adi,ad5706r.yaml | 96 ++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5706r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5706r.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..dabaf2195a07d2c66d44f69ca60e32e6bc37cf55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5706r.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5706r.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5706R 4-Channel Current Output DAC
> +
> +maintainers:
> + - Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
> +
> +description: |
> + The AD5706R is a 16-bit, 4-channel current output digital-to-analog
> + converter with SPI interface.
> +
> + The driver supports dynamic SPI clock rate management via an external

So this is DAC or driver? If driver, what does it drive?

> + clock generator (e.g., AXI CLKGEN) referenced by the 'clocks' property.
> + This allows separate read and write SPI speeds to be configured at
> + runtime.

How binding has anything to do with runtime? What are you describing
here?

> +
> + Datasheet:
> + https://www.analog.com/en/products/ad5706r.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad5706r
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:

So that's SPI then you miss $ref and unevaluatedProps. Look at other
bindings.

> + maximum: 100000000
> +
> + clocks:
> + maxItems: 1
> + description:
> + Reference clock for SPI clock rate management.
> +
> + clock-names:
> + items:
> + - const: spi_clk

Drop clock names, pretty redundant.

> +
> + pwms:
> + maxItems: 1
> +
> + pwm-names:
> + items:
> + - const: ad5706r_ldacb

No point to add device name in the input name.

> +
> + dac-resetb-gpios:

So reset-gpios?

> + maxItems: 1
> + description: GPIO connected to the active-low reset pin.
> +
> + dac-shdn-gpios:

Please read gpio-consumer-common.yaml

> + maxItems: 1
> + description: GPIO connected to the active-high shutdown pin.
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> + - clocks
> + - clock-names
> + - pwms
> + - pwm-names
> + - dac-resetb-gpios
> + - dac-shdn-gpios

No supplies? How does it get power or reference voltage?

> +

Here, missing allOf with ref

> +additionalProperties: false

And that is unevaluated.

Best regards,
Krzysztof