From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' Date: Fri, 18 Jul 2014 12:51:10 +0200 Message-ID: <53C8FC1E.9090003@nod.at> References: <201407130545.23004.marex@denx.de> <6823014.2plXDE9VA9@wuerfel> <53C7A819.40403@metafoo.de> <6485666.LVFO2YCEQx@wuerfel> <53C8114D.30601@nod.at> <53C86C10.2000608@gmail.com> <53C8CE59.3060103@nod.at> <53C8FA78.1020501@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53C8FA78.1020501@gmail.com> Sender: linux-input-owner@vger.kernel.org To: Chen Gang , Arnd Bergmann , Lars-Peter Clausen Cc: Guenter Roeck , Greg Kroah-Hartman , dmitry.torokhov@gmail.com, linux-iio@vger.kernel.org, Benjamin Herrenschmidt , teg@jklm.no, Thierry Reding , Lennox Wu , Marek Vasut , Liqin Chen , msalter@redhat.com, linux-pwm@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" , knaack.h@gmx.de, Martin Schwidefsky , Mischa.Jonker@synopsys.com, jic23@kernel.org, Geert Uytterhoeven List-Id: linux-pwm@vger.kernel.org Am 18.07.2014 12:44, schrieb Chen Gang: > On 07/18/2014 03:35 PM, Richard Weinberger wrote: >> Am 18.07.2014 02:36, schrieb Chen Gang: >>> >>> On 07/18/2014 02:09 AM, Richard Weinberger wrote: >>>> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>>>> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take >>>>> a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff >>>>> to build on UML seems pointless to me and we special-case it in a number of >>>>> places already. >>>> >>>> If UML is the only arch without io memory the dependency on !UML seems >>>> reasonable to me. :-) >>>> >>> >>> For me, if only uml left, I suggest to implement dummy functions within >>> uml instead of let CONFIG_UML appear in generic include directory. And >>> then remove all HAS_IOMEM and NO_IOMEM from kernel. >> >> Erm, this is something completely different. >> I thought we're focusing on COMPILE_TEST? >> > > COMPILE_TEST is none-architecture specific, but UML is. So in generic > include folder, if we're focusing on choosing whether COMPILE_TEST or > UML, for me, I will choose COMPILE_TEST. > > If we're not only focusing on COMPILE_TEST, for me, if something only > depend on one architecture, I'd like to put them under "arch/*/" folder. > > Especially, after that, we can remove all HAS_IOMEM and NO_IOMEM, nobody > has to think of them again. :-) And then we end up with a solution that on UML a lot of completely useless drivers are build which fail in various interesting manners because you'll add stubs for all kinds of io memory related functions to arch/um/? We had this kind of discussion already. You'll need more than ioremap... I like Arnd's idea *much* more to make COMPILE_TEST depend on !UML. Thanks, //richard