From: Bart Tanghe <bart.tanghe@thomasmore.be>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: matt.porter@linaro.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v7]pwm: add BCM2835 PWM driver
Date: Wed, 15 Oct 2014 12:33:29 +0200 [thread overview]
Message-ID: <543E4D79.3070405@thomasmore.be> (raw)
In-Reply-To: <20141014135445.GA26015@ulmo>
On 2014-10-14 15:54, Thierry Reding wrote:
> The above indicates that it would be 0x00, in which case it might be
> better to just do...
>
> value &= ~(PWM_CONTROL_MASK << (PWM_CONTROL_STRIDE * pwm->hwpwm));
>
> ... and get rid of DEFAULT_PWM_MODE.
Indeed, this has to be 0x00. PWM_CONTROL_MASK and DEFAULT_PWM_MODE are the same.
I've declared DEFAULT_PWM_MODE because they have another meaning but the values are the same.
You can definetly use
value &= ~(PWM_CONTROL_MASK << (PWM_CONTROL_STRIDE * pwm->hwpwm));
Bart
prev parent reply other threads:[~2014-10-15 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 10:14 [PATCH v7]pwm: add BCM2835 PWM driver Bart Tanghe
2014-10-08 12:19 ` Thierry Reding
2014-10-08 14:02 ` Bart Tanghe
2014-10-08 16:30 ` Stephen Warren
2014-10-14 13:54 ` Thierry Reding
2014-10-15 10:33 ` Bart Tanghe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543E4D79.3070405@thomasmore.be \
--to=bart.tanghe@thomasmore.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matt.porter@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).