From: Tomasz Figa <t.figa@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
tomasz.figa@gmail.com, Andrew Bresticker <abrestic@chromium.org>
Subject: Re: [PATCH 1/1] pwm: samsung: avoid setting manual update bit unnecessarily
Date: Thu, 28 Nov 2013 14:44:14 +0100 [thread overview]
Message-ID: <5465670.GCi1FFbjRb@amdc1227> (raw)
In-Reply-To: <20131128132640.GA23201@ulmo.nvidia.com>
On Thursday 28 of November 2013 14:26:41 Thierry Reding wrote:
> On Wed, Oct 30, 2013 at 10:21:44AM +0530, Sachin Kamat wrote:
> > From: Andrew Bresticker <abrestic@chromium.org>
> >
> > When possible, avoid setting the manual update bit and starting/stopping
> > the PWM when adjusting the PWM as it causes noticable flickering when
> > setting the backlight brightness.
> >
> > Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > drivers/pwm/pwm-samsung.c | 23 +++++++++++++++++++----
> > 1 file changed, 19 insertions(+), 4 deletions(-)
>
> There has been no comment on this, so can I assume this is fine with
> everyone?
Oops. Seems like I missed this particular patch. Hold on a while,
I'm looking at it right now.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-11-28 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 4:51 [PATCH 1/1] pwm: samsung: avoid setting manual update bit unnecessarily Sachin Kamat
2013-11-28 13:26 ` Thierry Reding
2013-11-28 13:44 ` Tomasz Figa [this message]
2013-11-28 14:05 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465670.GCi1FFbjRb@amdc1227 \
--to=t.figa@samsung.com \
--cc=abrestic@chromium.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox