Re: [PATCH v5 087/111] pwm: sl28cpld: Make use of devm_pwmchip_alloc() function

[Michael Walle <mwalle@kernel.org>]

>> >  static inline struct sl28cpld_pwm *sl28cpld_pwm_from_chip(struct
>> > pwm_chip *chip)
>> >  {
>> > -	return container_of(chip, struct sl28cpld_pwm, chip);
>> > +	return pwmchip_get_drvdata(chip);
>> 
>> This function now seems superfluous. Better use
>> pwmchip_get_drvdata(chip) directly.
>> 
>> If you don't respin or this is too much work, I can
>> send a patch once this is applied.
> 
> I like it keeping around, becuase it returns the right type (instead of
> pwmchip_get_drvdata() which returns void). Also it might be beneficial
> to mark this function with the const attribute. If you want to care for
> this, that would be very welcome.

It's a matter of taste I guess, so I'm fine with either. It's only used 
in
two places. If you return const you can't use it in the probe function. 
And
using pwmchip_get_drvdata() just there is worse.

-michael