From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
thierry.reding@gmail.com
Cc: zmxu@marvell.com, jszhang@marvell.com,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] Documentation: bindings: document the Berlin PWM driver
Date: Mon, 10 Aug 2015 21:44:11 +0200 [thread overview]
Message-ID: <55C8FF0B.50203@gmail.com> (raw)
In-Reply-To: <1438248201-29222-3-git-send-email-antoine.tenart@free-electrons.com>
On 30.07.2015 11:23, Antoine Tenart wrote:
> Following the addition of a Berlin PWM driver, this patch adds the
> corresponding documentation.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-berlin.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-berlin.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-berlin.txt b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt
> new file mode 100644
> index 000000000000..3d7ab7bfbf54
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt
> @@ -0,0 +1,15 @@
> +Berlin PWM controller
Just a little sentence about "PWM IP found in Marvell Berlin SoCs" ?
Besides that, this looks pretty straight-forward to me. Feel free
to add my
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
for the Berlin part of it.
Sebastian
> +Required properties:
> +- compatible: should be "marvell,berlin-pwm"
> +- reg: physical base address and length of the controller's registers
> +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of
> + the cells format.
> +
> +Example:
> +
> +pwm: pwm@f7f20000 {
> + compatible = "marvell,berlin-pwm";
> + reg = <0xf7f20000 0x40>;
> + #pwm-cells = <3>;
> +}
>
next prev parent reply other threads:[~2015-08-10 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 9:23 [PATCH v2 0/5] ARM: berlin: PWM support Antoine Tenart
2015-07-30 9:23 ` [PATCH v2 1/5] pwm: add the Berlin pwm controller driver Antoine Tenart
2015-07-31 3:12 ` Jisheng Zhang
2015-08-10 19:42 ` Sebastian Hesselbarth
2015-07-30 9:23 ` [PATCH v2 2/5] Documentation: bindings: document the Berlin PWM driver Antoine Tenart
2015-08-10 19:44 ` Sebastian Hesselbarth [this message]
2015-07-30 9:23 ` [PATCH v2 3/5] ARM: berlin: add a PWM node on the BG2Q Antoine Tenart
2015-07-30 9:23 ` [PATCH v2 4/5] ARM: berlin: add a PWM node on the BG2 Antoine Tenart
2015-08-10 19:51 ` Sebastian Hesselbarth
2015-08-11 2:46 ` Jisheng Zhang
2015-07-30 9:23 ` [PATCH v2 5/5] ARM: berlin: add a PWM node on the BG2CD Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8FF0B.50203@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).