From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v2 4/5] ARM: berlin: add a PWM node on the BG2 Date: Mon, 10 Aug 2015 21:51:44 +0200 Message-ID: <55C900D0.9060606@gmail.com> References: <1438248201-29222-1-git-send-email-antoine.tenart@free-electrons.com> <1438248201-29222-5-git-send-email-antoine.tenart@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438248201-29222-5-git-send-email-antoine.tenart@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org To: Antoine Tenart , thierry.reding@gmail.com Cc: zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pwm@vger.kernel.org On 30.07.2015 11:23, Antoine Tenart wrote: > This patch adds a PWM node in the Berlin BG2 device tree, using the > newly added Berlin PWM driver. > > Signed-off-by: Antoine Tenart > --- > arch/arm/boot/dts/berlin2.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi > index ef811de09908..e17bd5faed27 100644 > --- a/arch/arm/boot/dts/berlin2.dtsi > +++ b/arch/arm/boot/dts/berlin2.dtsi > @@ -512,5 +512,11 @@ > interrupts = ; > }; > }; > + > + pwm: pwm@f20000 { > + compatible = "marvell,berlin-pwm"; > + reg = <0xf20000 0x40>; > + #pwm-cells = <3>; > + }; I only checked berlin2.dtsi: The top most line with belongs to a sub-node of apb@fc0000 - which means that the pwm node isn't sorted in by address. Please sort the nodes by address in all three DT patches. BTW, is there any IRQ from the PWM IP routed to any intc upstream? A quick look into some BSP code does not reveal any hints maybe one of the Marvell guys can comment on it. Sebastian > }; > }; >