From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB949EE49A3 for ; Wed, 23 Aug 2023 04:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231966AbjHWE7O (ORCPT ); Wed, 23 Aug 2023 00:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbjHWE7O (ORCPT ); Wed, 23 Aug 2023 00:59:14 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6224E57 for ; Tue, 22 Aug 2023 21:59:11 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fefe898f76so7189675e9.0 for ; Tue, 22 Aug 2023 21:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1692766750; x=1693371550; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jZaDZO+v9MG56Hk5iDml8pLk4+3/ykfx331epWISZyM=; b=d16jqq2HnbhQHvSV2h6DfNUd0Y+F+yQ0b7M7C/d9RrDSO0GhCJd4uRo0Jo2tS/uyzC 8IZXu8NKUlej4O30KKueOVtll6DYvKPDtYb3Pg9FKPq7T5/5e5bMLZZ66Y1UrTLW3ovp NNZIZK0EyngNrXx1mgVWWP0fV75vn2gMBk5Pv8zogwozpmqI6YSu58rqsrXkhYf2VYKd jnTxCdockbTL8G1NDwIKbnxdj8ugDPqKScO5+gbtfyoHwtiT5rck/d8RAn4JawsHIm0Z sWoFc0y8JIZz/58tJVx0vT3i91msvGWvKeGkd6AOmxKNLM5oRMxCUlHwQC4jNibWCYpl cd+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692766750; x=1693371550; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jZaDZO+v9MG56Hk5iDml8pLk4+3/ykfx331epWISZyM=; b=lkD9l6zDvm+WYi2SZ0OpsDb5im6BYcIjwbUL5lYBKiiZRieEr1QEYXP57MMX4I2T6y 1qbuTgtSxter9nTDlx6hbh6ynZcahKmQe6JFOY4udeWBMOK14xtaSyD56xE98FZVGKR4 mEVtb5KqRgPKWiRKYm5IzGHJ6ArLUTdme34280Ujt4YMRYolRY3jhi0cy9pgQLVUsP9w kRWsED6UQrQqppSeMTWs3DDIMlcGXLegkHeTe0rIwSxO/9nURM1GBcaONaOg7XC58mcG bPxUqhrGMFx/LPY1oxx/QjaEMy49RXlMdA9xLPEH2mXPN8fcS9oYq7LhGyY8JuxwncqN t4pA== X-Gm-Message-State: AOJu0YzSTSkhYwHgk0S1MYRps55H7+/92g3v8f3HsHG1uEOROjEhbnGl kV8oACd8WuBdcqDqcoap/i8mlg== X-Google-Smtp-Source: AGHT+IF6wT5V6T7EB1mYVkojEC/SkS1mcOnC7jSw0mHdobHGbBcN78NnKG+2UwwFBBmGZgvVKOowEA== X-Received: by 2002:a5d:6382:0:b0:319:8bd0:d18c with SMTP id p2-20020a5d6382000000b003198bd0d18cmr7788581wru.52.1692766750235; Tue, 22 Aug 2023 21:59:10 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.1]) by smtp.gmail.com with ESMTPSA id w1-20020a5d6081000000b0031773e3cf46sm17505270wrt.61.2023.08.22.21.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Aug 2023 21:59:09 -0700 (PDT) Message-ID: <5663e3e6-de16-e9ba-0745-b9a40676b109@tuxon.dev> Date: Wed, 23 Aug 2023 07:59:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] pwm: atmel: add missing clk_disable_unprepare() Content-Language: en-US To: Hari Prasath Gujulan Elango , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230822070441.22170-1-Hari.PrasathGE@microchip.com> From: claudiu beznea In-Reply-To: <20230822070441.22170-1-Hari.PrasathGE@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On 8/22/23 10:04, Hari Prasath Gujulan Elango wrote: > Fix the below smatch warning: > > drivers/pwm/pwm-atmel-hlcdc.c:167 atmel_hlcdc_pwm_apply() warn: 'new_clk' from clk_prepare_enable() not released on lines: 112,137,142,149. > Can you add a fixes tag? > Signed-off-by: Hari Prasath Gujulan Elango > --- > drivers/pwm/pwm-atmel-hlcdc.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c > index 96a709a9d49a..ce46f6c74a14 100644 > --- a/drivers/pwm/pwm-atmel-hlcdc.c > +++ b/drivers/pwm/pwm-atmel-hlcdc.c > @@ -108,8 +108,10 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm, > ATMEL_HLCDC_CFG(0), > ATMEL_HLCDC_CLKPWMSEL, > gencfg); > - if (ret) > + if (ret) { > + clk_disable_unprepare(new_clk); > return ret; > + } > } > > do_div(pwmcval, state->period); > @@ -133,20 +135,27 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm, > ATMEL_HLCDC_PWMPS_MASK | > ATMEL_HLCDC_PWMPOL, > pwmcfg); > - if (ret) > + if (ret) { > + clk_disable_unprepare(new_clk); > return ret; > + } > > ret = regmap_write(hlcdc->regmap, ATMEL_HLCDC_EN, > ATMEL_HLCDC_PWM); > - if (ret) > + if (ret) { > + clk_disable_unprepare(new_clk); > return ret; > + } > > ret = regmap_read_poll_timeout(hlcdc->regmap, ATMEL_HLCDC_SR, > status, > status & ATMEL_HLCDC_PWM, > 10, 0); > - if (ret) > + if (ret) { > + clk_disable_unprepare(new_clk); Can you keep a single failure point for all these? Also, you have to set chip->cur_clk = NULL otherwise next time your apply will get executed the new_clk will not be enabled. Thank you, Claudiu Beznea > return ret; > + } > + > } else { > ret = regmap_write(hlcdc->regmap, ATMEL_HLCDC_DIS, > ATMEL_HLCDC_PWM);