linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: thierry.reding@gmail.com, tony@atomide.com, paul@pwsan.com,
	t-kristo@ti.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, vigneshr@ti.com, nsekhar@ti.com
Subject: Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address
Date: Thu, 28 Apr 2016 16:41:31 -0500	[thread overview]
Message-ID: <5722838B.7070309@ti.com> (raw)
In-Reply-To: <20160428213122.GA27352@rob-hp-laptop>



On 04/28/2016 04:31 PM, Rob Herring wrote:
> On Tue, Apr 26, 2016 at 05:36:44PM -0500, Franklin S Cooper Jr wrote:
>> Replace unit address from 0 to the proper physical address.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>>  Documentation/devicetree/bindings/pwm/pwm-tiecap.txt | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> index 788da6c..1b7eec5 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> @@ -16,21 +16,21 @@ Optional properties:
>>  
>>  Example:
>>  
>> -ecap0: ecap@0 { /* ECAP on am33xx */
>> +ecap0: ecap@48300100 { /* ECAP on am33xx */
>>  	compatible = "ti,am33xx-ecap";
>>  	#pwm-cells = <3>;
>>  	reg = <0x48300100 0x80>;
>>  	ti,hwmods = "ecap0";
>>  };
>>  
>> -ecap0: ecap@0 { /* ECAP on am4372 */
>> +ecap0: ecap@48300100 { /* ECAP on am4372 */
>>  	compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>>  	#pwm-cells = <3>;
>>  	reg = <0x48300100 0x80>;
>>  	ti,hwmods = "ecap0";
>>  };
>>  
>> -ecap0: ecap@0 { /* ECAP on da850 */
>> +ecap0: ecap@1f06000 { /* ECAP on da850 */
>>  	compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>>  	#pwm-cells = <3>;
>>  	reg = <0x306000 0x80>;
> 
> These still don't match.
> 
> Rob


I apologize you made a similar comment in the past but I misinterpreted
it recently which is why I made the same mistake again. I'll fix it.

Any issue with my response to your patch two comment for why I did
things the way I did? If so I can fix it when I send my new rev.

> 
>> -- 
>> 2.7.0
>>

  reply	other threads:[~2016-04-28 21:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 22:36 [PATCH v7 0/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node Franklin S Cooper Jr
2016-04-27 12:48   ` Tero Kristo
2016-04-26 22:36 ` [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM binding documents Franklin S Cooper Jr
2016-04-28 21:07   ` Rob Herring
2016-04-28 21:11     ` Franklin S Cooper Jr.
2016-04-28 21:55       ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 3/9] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address Franklin S Cooper Jr
2016-04-28 21:31   ` Rob Herring
2016-04-28 21:41     ` Franklin S Cooper Jr. [this message]
2016-04-26 22:36 ` [PATCH v7 5/9] ARM: dts: am437x/am33xx/da850: Add new ECAP and EPWM bindings Franklin S Cooper Jr
2016-04-28 21:35   ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 6/9] pwms: pwm-ti*: Get the clock from the PWMSS parent when using old bindings Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 7/9] ARM: dts: am437x/am33xx: Remove hwmod entries for ECAP and EPWM nodes Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 8/9] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 9/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-27 19:32 ` [PATCH v7 0/9] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5722838B.7070309@ti.com \
    --to=fcooper@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=paul@pwsan.com \
    --cc=robh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).