From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: (EXT) [PATCH] pwm: Document that the pinstate of a disabled PWM isn't reliable
Date: Wed, 18 May 2022 09:08:50 +0200 [thread overview]
Message-ID: <5725729.MhkbZ0Pkbq@steina-w> (raw)
In-Reply-To: <20220517150555.404363-1-u.kleine-koenig@pengutronix.de>
Am Dienstag, 17. Mai 2022, 17:05:55 CEST schrieb Uwe Kleine-König:
> Some (most?) drivers emit the inactive state when the PWM is disabled.
> However there are exceptions, so document that a consumer better doesn't
> depend on this behaviour.
>
> Some known exceptions:
>
> - imx27 emits 0 independent of the configured polarity
> - mxs just drives the output to the last emitted state.
> - iqs620a makes the output tristated on disable, so an external
> pull-down would be required.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Documentation/driver-api/pwm.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/driver-api/pwm.rst
> b/Documentation/driver-api/pwm.rst index ccb06e485756..fd26c3d895b6 100644
> --- a/Documentation/driver-api/pwm.rst
> +++ b/Documentation/driver-api/pwm.rst
> @@ -49,6 +49,12 @@ After being requested, a PWM has to be configured using::
>
> This API controls both the PWM period/duty_cycle config and the
> enable/disable state.
> +
> +As a consumer, don't rely on the output's state for a disabled PWM. If it's
> +easily possible, drivers are supposed to emit the inactive state, but some
> +drivers cannot. If you rely on getting the inactive state, use
> .duty_cycle=0, +.enabled=true.
> +
> There is also a usage_power setting: If set, the PWM driver is only
> required to maintain the power output but has more freedom regarding signal
> form. If supported by the driver, the signal can be optimized, for example
> to improve
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
prev parent reply other threads:[~2022-05-18 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 15:05 [PATCH] pwm: Document that the pinstate of a disabled PWM isn't reliable Uwe Kleine-König
2022-05-18 7:08 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5725729.MhkbZ0Pkbq@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox