From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5EBE743F3 for ; Fri, 29 Sep 2023 07:56:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232613AbjI2H4I (ORCPT ); Fri, 29 Sep 2023 03:56:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232490AbjI2H4G (ORCPT ); Fri, 29 Sep 2023 03:56:06 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0E219F; Fri, 29 Sep 2023 00:56:05 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38T7Db1L030144; Fri, 29 Sep 2023 07:55:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Aq07fqq33pAukshYyhActJ+ssU9SFqTlkx54bSTgIc4=; b=j8VLwfzBJF18kqqMR0DjV1AUDxcLAom+Xl/EmSkchxKKLuCHNyvm36YMOpjVdRnChm1Z ny7VoLYGRpztrh5Ryp5d3WkYUbKCzqaGKos6v9thhk126UDYHyb2y2dPdNG6yK5ZTHR/ UmfW689CrHjS1+E0ih02Ql+dP48ddLkYVTBbbhwSoaBTgRRQMriHJRnd4E/2/1/KtClG 8eo3hMQQ+15cgKeTjGxQI4fpCYY3JvNKgyC0f5KjF3lmimPbYXztsWJB1MsklzZQJSK3 ZjLM8AZvyebDu13vOyX8RPJNDbgLh14r+aCiCDSBJb20ryYIrfnR16Oz7DtnecMky9UP Ig== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3td8wdt589-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 07:55:26 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38T7tNpw029488 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 07:55:23 GMT Received: from [10.216.56.186] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 29 Sep 2023 00:55:17 -0700 Message-ID: <59c9dbdb-8673-8dc7-ecca-32ff120ccf80@quicinc.com> Date: Fri, 29 Sep 2023 13:25:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH V12 2/3] dt-bindings: pwm: add IPQ6018 binding To: Krzysztof Kozlowski , , , , , , , , , , , , , , CC: , , References: <20230925065915.3467964-1-quic_devipriy@quicinc.com> <20230925065915.3467964-3-quic_devipriy@quicinc.com> <42338d41-1b90-4f77-958e-479d32e0ce1d@linaro.org> Content-Language: en-US From: Devi Priya In-Reply-To: <42338d41-1b90-4f77-958e-479d32e0ce1d@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: AH63YybTtZJ9y3v7PS-rCRW7ELPgjjSP X-Proofpoint-GUID: AH63YybTtZJ9y3v7PS-rCRW7ELPgjjSP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-29_05,2023-09-28_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxscore=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309290066 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On 9/25/2023 12:41 PM, Krzysztof Kozlowski wrote: > On 25/09/2023 08:59, Devi Priya wrote: >> DT binding for the PWM block in Qualcomm IPQ6018 SoC. >> >> Reviewed-by: Bjorn Andersson >> Co-developed-by: Baruch Siach >> Signed-off-by: Baruch Siach >> Signed-off-by: Devi Priya > > ... > >> diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml >> new file mode 100644 >> index 000000000000..857086ad539e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > Filename matching compatible, so qcom,ipq6018-pwm.yaml okay > >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm IPQ6018 PWM controller >> + >> +maintainers: >> + - Baruch Siach >> + >> +properties: >> + "#pwm-cells": >> + const: 2 >> + >> + compatible: >> + const: qcom,ipq6018-pwm > > compatible is always the first property. okay > >> + >> + reg: >> + description: Offset of PWM register in the TCSR block. >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - "#pwm-cells" > > And this order must be the same as in properties. okay > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + syscon@1937000 { >> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd"; >> + reg = <0x01937000 0x21000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0 0x1937000 0x21000>; > > Drop this node, not related. The parent binding could have full example, > on the other hand. Additionally, I have doubts that you really tested > the parent binding. Sure, will drop the syscon node Thanks, Devi Priya > >> + >> + pwm: pwm@a010 { >> + compatible = "qcom,ipq6018-pwm"; > > Best regards, > Krzysztof >