From: Javier Martinez Canillas <javierm@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Fbdev development list" <linux-fbdev@vger.kernel.org>,
"Maxime Ripard" <maxime@cerno.tech>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Lee Jones" <lee.jones@linaro.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux PWM List" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v4 3/6] drm: Add driver for Solomon SSD130x OLED displays
Date: Fri, 11 Feb 2022 13:27:12 +0100 [thread overview]
Message-ID: <5b451266-0217-fc4c-794b-453c4e6439f6@redhat.com> (raw)
In-Reply-To: <CAMuHMdVLmUwgCWui4OiZqvqpVWzA-d9QhjZLa_idgC19XeEEjA@mail.gmail.com>
Hello Geert,
On 2/11/22 13:23, Geert Uytterhoeven wrote:
[snip]
>>>> + if (IS_ERR(bl)) {
>>>
>>>> + ret = PTR_ERR(bl);
>>>> + dev_err_probe(dev, ret, "Unable to register backlight device\n");
>>>> + return ERR_PTR(ret);
>>>
>>> dev_err_probe(dev, PTR_ERR(bl), "Unable to register backlight device\n");
>>> return bl;
>>>
>>> ?
>>
>> No, because this function's return value is a struct ssd130x_device pointer,
>> not a struct backlight_device pointer.
>
> Hence
>
> return ERR_PTR(dev_err_probe(dev, PTR_ERR(bl),
> "Unable to register backlight device\n"));
>
> ?
>
Thanks, that would work.
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-02-11 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 9:19 [PATCH v4 0/6] drm: Add driver for Solomon SSD130x OLED displays Javier Martinez Canillas
2022-02-11 9:19 ` [PATCH v4 3/6] " Javier Martinez Canillas
2022-02-11 11:33 ` Andy Shevchenko
2022-02-11 12:05 ` Javier Martinez Canillas
2022-02-11 12:23 ` Geert Uytterhoeven
2022-02-11 12:27 ` Javier Martinez Canillas [this message]
2022-02-11 15:49 ` Andy Shevchenko
2022-02-11 12:44 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b451266-0217-fc4c-794b-453c4e6439f6@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).