From: neil.armstrong@linaro.org
To: George Stark <gnstark@salutedevices.com>,
u.kleine-koenig@pengutronix.de, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com
Cc: linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH 3/3] pwm: meson: Enable constant and polarity features for g12, axg, s4
Date: Tue, 8 Oct 2024 09:31:09 +0200 [thread overview]
Message-ID: <5c3a6fdb-e4f0-4a22-9a8d-84baee12769c@linaro.org> (raw)
In-Reply-To: <20241007193203.1753326-4-gnstark@salutedevices.com>
On 07/10/2024 21:32, George Stark wrote:
> g12, axg and s4 SoC families support constant and polarity bits so enable
> those features in corresponding chip data structs.
>
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> ---
> drivers/pwm/pwm-meson.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 6701738c55e3..c6f032bdfe78 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -571,26 +571,36 @@ static const struct meson_pwm_data pwm_gxbb_ao_data = {
> static const struct meson_pwm_data pwm_axg_ee_data = {
> .parent_names = { "xtal", "fclk_div5", "fclk_div4", "fclk_div3" },
> .channels_init = meson_pwm_init_channels_meson8b_legacy,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct meson_pwm_data pwm_axg_ao_data = {
> .parent_names = { "xtal", "axg_ao_clk81", "fclk_div4", "fclk_div5" },
> .channels_init = meson_pwm_init_channels_meson8b_legacy,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct meson_pwm_data pwm_g12a_ee_data = {
> .parent_names = { "xtal", NULL, "fclk_div4", "fclk_div3" },
> .channels_init = meson_pwm_init_channels_meson8b_legacy,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct meson_pwm_data pwm_g12a_ao_ab_data = {
> .parent_names = { "xtal", "g12a_ao_clk81", "fclk_div4", "fclk_div5" },
> .channels_init = meson_pwm_init_channels_meson8b_legacy,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct meson_pwm_data pwm_g12a_ao_cd_data = {
> .parent_names = { "xtal", "g12a_ao_clk81", NULL, NULL },
> .channels_init = meson_pwm_init_channels_meson8b_legacy,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct meson_pwm_data pwm_meson8_v2_data = {
> @@ -599,6 +609,8 @@ static const struct meson_pwm_data pwm_meson8_v2_data = {
>
> static const struct meson_pwm_data pwm_s4_data = {
> .channels_init = meson_pwm_init_channels_s4,
> + .has_constant = true,
> + .has_polarity = true,
> };
>
> static const struct of_device_id meson_pwm_matches[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-10-08 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 19:32 [PATCH 0/3] pwm: meson: Support constant and polarity bits George Stark
2024-10-07 19:32 ` [PATCH 1/3] " George Stark
2024-10-08 7:30 ` neil.armstrong
2024-10-07 19:32 ` [PATCH 2/3] pwm: meson: Use separate chip data struct for g12a-ee-pwm George Stark
2024-10-08 7:30 ` neil.armstrong
2024-10-07 19:32 ` [PATCH 3/3] pwm: meson: Enable constant and polarity features for g12, axg, s4 George Stark
2024-10-08 7:31 ` neil.armstrong [this message]
2024-10-08 12:37 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3a6fdb-e4f0-4a22-9a8d-84baee12769c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=gnstark@salutedevices.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox