Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

Arnd Bergmann
2014-07-22T10:32:06Z

On Sunday 20 July 2014 17:45:40 Chen Gang wrote:
> >
> > Next, I shall:
> >
> > - Remove HAS_IOMEM and NO_IOMEM from kernel, firstly.
> >
> > - Try to make dummy IOMEM functions for score architecture.
> >
> > - Continue discussing with UML for it.
> >
>
> Oh, sorry, I forgot, after remove IOMEM from kernel, also s390 and tile
> need implement dummy IOMEM if !PCI.
>
> If possible, I shall try to implement the dummy IOMEM in 'asm-generic',
> and let uml, score, s390 and tile use them when they need.

Sorry for going round in circles, but looking back at the original patches,
adding the extra 'depends on HAS_IOMEM' does seem much better than the
other suggestions that came afterwards.

In particular, removing HAS_IOMEM and NO_IOMEM sounds like an awful idea
to me. I'd rather add a HAS_IOPORT in addition to also catch architectures
that have no support for PC-style PIO.

Arnd