From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
linux-mips@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] pwm: jz4740: Consistently name driver data "jz"
Date: Thu, 10 Aug 2023 10:57:54 +0200 [thread overview]
Message-ID: <7725bc47-c557-5874-e7e0-3d746febbe86@linaro.org> (raw)
In-Reply-To: <20230808062608.897710-1-u.kleine-koenig@pengutronix.de>
On 8/8/23 08:26, Uwe Kleine-König wrote:
> Most but not all pointers to driver data are already called "jz":
>
> $ git grep 'struct jz4740_pwm_chip \*' v6.5-rc1 -- drivers/pwm/pwm-jz4740.c
> v6.5-rc1:drivers/pwm/pwm-jz4740.c:static inline struct jz4740_pwm_chip *to_jz4740(struct pwm_chip *chip)
> v6.5-rc1:drivers/pwm/pwm-jz4740.c:static bool jz4740_pwm_can_use_chn(struct jz4740_pwm_chip *jz,
> v6.5-rc1:drivers/pwm/pwm-jz4740.c: struct jz4740_pwm_chip *jz = to_jz4740(chip);
> v6.5-rc1:drivers/pwm/pwm-jz4740.c: struct jz4740_pwm_chip *jz = to_jz4740(chip);
> v6.5-rc1:drivers/pwm/pwm-jz4740.c: struct jz4740_pwm_chip *jz = to_jz4740(chip);
> v6.5-rc1:drivers/pwm/pwm-jz4740.c: struct jz4740_pwm_chip *jz4740 = to_jz4740(pwm->chip);
> v6.5-rc1:drivers/pwm/pwm-jz4740.c: struct jz4740_pwm_chip *jz4740;
>
> Adapt the two variables called "jz4740" to use the same name for
> consistency.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-jz4740.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-08-10 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 6:26 [PATCH] pwm: jz4740: Consistently name driver data "jz" Uwe Kleine-König
2023-08-10 8:57 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7725bc47-c557-5874-e7e0-3d746febbe86@linaro.org \
--to=philmd@linaro.org \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox