From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de
Subject: Re: [PATCH 03/11] pwm: brcmstb: Simplify using devm functions
Date: Sun, 12 Nov 2023 20:22:22 -0800 [thread overview]
Message-ID: <7ef7d184-9923-4c36-89d8-04d384806176@broadcom.com> (raw)
In-Reply-To: <20230929161918.2410424-4-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On 9/29/2023 9:19 AM, Uwe Kleine-König wrote:
> With devm_clk_get_enabled() the call to clk_disable_unprepare() can be
> dropped from the error path and the remove callback. With
> devm_pwmchip_add() pwmchip_remove() can be dropped. Then the remove
> callback is empty and can go away, too.
>
> Also use dev_err_probe() for simplified (and improved) error reporting.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-11-13 4:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:19 [PATCH 00/11] pwm: Some random cleanups Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 01/11] pwm: bcm-iproc: Simplify using devm functions Uwe Kleine-König
2023-11-13 4:11 ` Florian Fainelli
2023-11-13 8:35 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 02/11] pwm: bcm2835: " Uwe Kleine-König
2023-11-13 4:21 ` Florian Fainelli
2023-09-29 16:19 ` [PATCH 03/11] pwm: brcmstb: " Uwe Kleine-König
2023-11-13 4:22 ` Florian Fainelli [this message]
2023-09-29 16:19 ` [PATCH 04/11] pwm: imx-tpm: " Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 05/11] pwm: mtk-disp: Simplify using devm_pwmchip_add() Uwe Kleine-König
2023-10-02 10:44 ` AngeloGioacchino Del Regno
2023-09-29 16:19 ` [PATCH 06/11] pwm: spear: Simplify using devm functions Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 07/11] pwm: sprd: Provide a helper to cast a chip to driver data Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 08/11] pwm: sprd: Simplify using devm_pwmchip_add() and dev_err_probe() Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 09/11] pwm: vt8500: Simplify using devm functions Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 10/11] pwm: samsung: Consistently use the same name for driver data Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 11/11] pwm: cros-ec: Simplify using devm_pwmchip_add() and dev_err_probe() Uwe Kleine-König
2023-10-02 6:01 ` Tzung-Bi Shih
2023-11-13 3:23 ` [PATCH 00/11] pwm: Some random cleanups patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef7d184-9923-4c36-89d8-04d384806176@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox