From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro Date: Fri, 24 Apr 2020 09:17:58 +0300 Message-ID: <87ftctbe5l.fsf@intel.com> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mga02.intel.com ([134.134.136.20]:24165 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgDXGSF (ORCPT ); Fri, 24 Apr 2020 02:18:05 -0400 In-Reply-To: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: linux-pwm@vger.kernel.org Cc: Guru Das Srinagesh , David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6ni?= =?utf-8?Q?g?= , Subbaraman Narayanamurthy On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: "Ville Syrjälä" > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Superfluous blank line. Anyway, please preserve the existing acks and reviews [1] so people don't have to do it again. BR, Jani. [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > Signed-off-by: Guru Das Srinagesh > --- > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c > index 276f438..81547a0 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.c > +++ b/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, > return retval; > } > > - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > CRC_PMIC_PWM_PERIOD_NS); > panel->backlight.level = > intel_panel_compute_brightness(connector, level); -- Jani Nikula, Intel Open Source Graphics Center