Linux PWM subsystem development
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thierry Reding" <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org,
	Jens Gehrlein <J.Gehrlein@eckelmann.de>,
	kernel@pengutronix.de
Subject: Re: [PATCH] pwm: Adapt sysfs API documentation to reality
Date: Tue, 03 Oct 2023 09:35:46 -0600	[thread overview]
Message-ID: <87ttr7en1p.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230911154454.675057-1-u.kleine-koenig@pengutronix.de>

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

> Most low-level PWM drivers support duty_cycle == period, and so does the
> sysfs API. Also polarity can be changed for enabled PWMs since commit
> 39100ceea79f ("pwm: Switch to the atomic API").
>
> Reported-by: Jens Gehrlein <J.Gehrlein@eckelmann.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  Documentation/driver-api/pwm.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/driver-api/pwm.rst b/Documentation/driver-api/pwm.rst
> index 3fdc95f7a1d1..bb264490a87a 100644
> --- a/Documentation/driver-api/pwm.rst
> +++ b/Documentation/driver-api/pwm.rst
> @@ -111,13 +111,13 @@ channel that was exported. The following properties will then be available:
>  
>    duty_cycle
>      The active time of the PWM signal (read/write).
> -    Value is in nanoseconds and must be less than the period.
> +    Value is in nanoseconds and must be less than or equal to the period.
>  
>    polarity
>      Changes the polarity of the PWM signal (read/write).
>      Writes to this property only work if the PWM chip supports changing
> -    the polarity. The polarity can only be changed if the PWM is not
> -    enabled. Value is the string "normal" or "inversed".
> +    the polarity.
> +    Value is the string "normal" or "inversed".

I don't see this in linux-next yet, so I've gone ahead and applied it.

Thanks,

jon

      reply	other threads:[~2023-10-03 15:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 15:44 [PATCH] pwm: Adapt sysfs API documentation to reality Uwe Kleine-König
2023-10-03 15:35 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttr7en1p.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=J.Gehrlein@eckelmann.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox