From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro Date: Mon, 27 Apr 2020 16:48:39 +0300 Message-ID: <87y2qh9gzs.fsf@intel.com> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> <87ftctbe5l.fsf@intel.com> <20200424221756.GB31118@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mga06.intel.com ([134.134.136.31]:53448 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbgD0Nsr (ORCPT ); Mon, 27 Apr 2020 09:48:47 -0400 In-Reply-To: <20200424221756.GB31118@codeaurora.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Guru Das Srinagesh Cc: linux-pwm@vger.kernel.org, David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy On Fri, 24 Apr 2020, Guru Das Srinagesh wrote: > On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote: >> On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: >> > Since the PWM framework is switching struct pwm_state.duty_cycle's >> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL >> > to handle a 64-bit dividend. >> > >> > To: Jani Nikula >> > Cc: Joonas Lahtinen >> > Cc: David Airlie >> > Cc: Daniel Vetter >> > Cc: Chris Wilson >> > Cc: "Ville Syrjälä" >> > Cc: intel-gfx@lists.freedesktop.org >> > Cc: dri-devel@lists.freedesktop.org >> > >> >> Superfluous blank line. > > Will remove. > >> >> Anyway, please preserve the existing acks and reviews [1] so people >> don't have to do it again. >> >> BR, >> Jani. >> >> [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > > I dropped your Acked-by as the patch had to changed to resolve a merge > conflict when I rebased to tip. Could you please re-review this patch? Reviewed-by: Jani Nikula Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Graphics Center