From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB3E18C026 for ; Sun, 3 Nov 2024 22:10:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730671818; cv=none; b=ACwwbbqCXH1xre8ZiEvpYRjGAbGTt0UUMwdEuU89JA0G76xwQpcFIF8qfKcNm6qHRri8wLE/39a9xoPTXKfg2RAJ0jmcZ/0nrhbTEaGtmHsEfi5f6GdjmSLRCKN4qPhuQQjlC6arVGS0n4g7LV9Z0bN3ZNzr2ljt6GMzAynLW44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730671818; c=relaxed/simple; bh=YfV5iYFCey8uL8RvVFXKpCmMrpkP6Yn7Yg2LpgeM26E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HE1kEybj47fCVASU07KUWhpwKK08olSNDbGLgbotu8Gy64Bdke2tZZ8U3KBbxU/BPw5HDi4uPzwToU7NF76yyJHC06t2GKCijo26T/jQ+Lk8+sm9zbrAAdz+ne6xK7Jx6ZQiPqWl3y3O9sLHhimU07fW8u4YfMQngMW00HtJ4d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Vht3JLKE; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Vht3JLKE" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-71808b6246bso1929703a34.2 for ; Sun, 03 Nov 2024 14:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730671814; x=1731276614; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jUWYuqtR3aHLEhG7mg7lZrCRFDuphm1pLOvMuWzILNI=; b=Vht3JLKEVK758BtpHL1BLTVtaBpG2uF4Q3UG8skuu2U+kfcId35eHe7kNkDf6n0ZQY kudwvrbw6wVGJICEhd9mrurgYwJ1ViZNYV/JLUQmtxtsman9BFUuBOrWWtXomGo5cwzs adjrXDgzmCWLuO/8/WpicVXxPxz/q++jKMHrcbYNjsXunavpJpKv8mQbMxHJl3TzQ2O/ GfaaS5lWHtYtk8KowIifsY8ikWNC7jrx3VkEohZSuiNoroUANGklvt5VfkwjOyaLj44R Ph09aImoZQUFrZkKxKK6ogyVNJJr7Tw4Tm086A2bEJr9JSaDFrvzN1RC0/LkExSZg9OH TeIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730671814; x=1731276614; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jUWYuqtR3aHLEhG7mg7lZrCRFDuphm1pLOvMuWzILNI=; b=mFu7kPzqwNDsJ/+9lSyr2VsV+lQBDu0KRozU1MZMn2oAmkswjd7rrhA6WkNfKeCHWm h8hTXpusYX5I54mujfaAKXSdkeA1mndXdcgS/cOjX3CUAPtK4io72E3zXb1WrEs+5Ptv jg1HlHosjZ1vLJ5iTjbU+eiB6aSLfSo+gLLnxEOdptK1gDTexK8Jz4Hs62FZdy3J0PIf SMZ9RJwTcZIsZtPsb3F3MBUKOwTVdGhjXU0fvlBz5YkM1CVKLVw3qwZQhUeG3dPRFiUz t49/xDnAIZ0Rr35U9k74Y5cYBnqSXHOb2OVI3UZw+hHnc9wFCI79+EVoMuE6SfoG2uxn OskA== X-Forwarded-Encrypted: i=1; AJvYcCW5mQpAn7R9hni0N1gcN3iMsR06/cgXvwqpkaER9BvKXwbrk+3X7X0ECvwtGQ8pap11IIi06bKJ0HA=@vger.kernel.org X-Gm-Message-State: AOJu0YzCt1FOpWT6iZncJTCUzh7NsgfhB5kStBnrycOUThRMwVlrz+v1 zTNiyn34zlnyjoXYdIj/Cbbjf6MNlBQwXtxC6hTr+BnwrqY20rAP2pE5ZEyxN8k= X-Google-Smtp-Source: AGHT+IGMfVh9LXk0iaYFioOzlB6HVEvHUV0T09OtRUqjTerOH+6ZJQ5jtvM98lKCEUKMBpdWBa6SFw== X-Received: by 2002:a05:6830:310b:b0:718:118d:2be8 with SMTP id 46e09a7af769-719ca25bdd4mr6851108a34.28.1730671814414; Sun, 03 Nov 2024 14:10:14 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7189ccb15c0sm1745498a34.60.2024.11.03.14.10.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Nov 2024 14:10:13 -0800 (PST) Message-ID: <88b1e5a4-a962-4ef3-abff-724af2f6c09e@baylibre.com> Date: Sun, 3 Nov 2024 16:10:12 -0600 Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] iio: adc: ad7606: finish pwm_get_state_hw() TODO To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: kernel test robot , Jonathan Cameron , Guillaume Stols , oe-kbuild-all@lists.linux.dev, Michael Hennerich , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20241029-pwm-export-pwm_get_state_hw-v2-2-03ba063a3230@baylibre.com> <202411020101.5Hs6MkwQ-lkp@intel.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/3/24 2:20 PM, Uwe Kleine-König wrote: > On Sun, Nov 03, 2024 at 03:00:14PM +0100, Uwe Kleine-König wrote: >> Hello David, >> >> On Sat, Nov 02, 2024 at 01:50:35AM +0800, kernel test robot wrote: >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on 6fb2fa9805c501d9ade047fc511961f3273cdcb5] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/David-Lechner/pwm-core-export-pwm_get_state_hw/20241030-052134 >>> base: 6fb2fa9805c501d9ade047fc511961f3273cdcb5 >>> patch link: https://lore.kernel.org/r/20241029-pwm-export-pwm_get_state_hw-v2-2-03ba063a3230%40baylibre.com >>> patch subject: [PATCH v2 2/2] iio: adc: ad7606: finish pwm_get_state_hw() TODO >>> config: i386-randconfig-141-20241101 (https://download.01.org/0day-ci/archive/20241102/202411020101.5Hs6MkwQ-lkp@intel.com/config) >>> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 >>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411020101.5Hs6MkwQ-lkp@intel.com/reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202411020101.5Hs6MkwQ-lkp@intel.com/ >>> >>> All errors (new ones prefixed by >>): >>> >>> drivers/iio/adc/ad7606.c: In function 'ad7606_read_raw': >>>>> drivers/iio/adc/ad7606.c:765:23: error: implicit declaration of function 'pwm_get_state_hw'; did you mean 'pwm_get_state'? [-Werror=implicit-function-declaration] >>> 765 | ret = pwm_get_state_hw(st->cnvst_pwm, &cnvst_pwm_state); >>> | ^~~~~~~~~~~~~~~~ >>> | pwm_get_state >>> cc1: some warnings being treated as errors >> >> The problem here is that there is no declaration (and implementation) of >> pwm_get_state_hw() with CONFIG_PWM=n. Does it make sense to enable the >> ad7606 driver without enabling PWM support? If yes, we should add a >> dummy implementation of pwm_get_state_hw(), if not, a depends on PWM >> should be introduced. > > Looking at the driver, the PWM is optional. So I rewrote the commit from > patch 1/2 in this series and added a dummy. > > Best regards > Uwe Thanks!